aboutsummaryrefslogtreecommitdiffstats
path: root/includes/Wiki.php
Commit message (Collapse)AuthorAgeFilesLines
* Rename Wiki.php to MediaWiki.phpwithoutaname2014-07-131-722/+0
| | | | | | This only renames the file, not the class itself. Change-Id: I53dfa5ae98c8f45b32f911419217692cfd760cd7
* Added BeforeHttpsRedirect hook allowing extensions to cancel forceHTTPSYuri Astrakhan2014-05-281-23/+26
| | | | | | | | | | | | | | For ZERO, we need to be able to avoid forceHTTPS from taking place in case user logged in while on wifi, and later switched to zero.wikipedia.org for the carrier who doesn't support HTTPS. In that case, the extension will need to be able to cancel redirect and force regular HTTP handling. Open Question: should this code log off user in case hook returns false? Bug 65567 Change-Id: If04c83066c5d47b3c04ad7674e3c4e95a4cd464b
* MediaWiki::performAction, return 404 on nosuchaction errorSergio Santoro2014-05-221-0/+1
| | | | | | | Nosuchaction error page was sending 200 as the HTTP status code, which was misleading. Instead return 404. Change-Id: I9b432c9e53caf0a13e9a0c798f78a7bd8a78443b
* Make phpcs-strict pass on includes/ (4/~10)Siebrand Mazeland2014-05-111-3/+6
| | | | Change-Id: I2767205a7059adfb8fa090a82abd332e518f2590
* http -> https rewrite: Only replace one http by httpsumherirrender2014-04-281-1/+1
| | | | | | | | | | | | This avoids changing from http://de.wikipedia.org/wiki/Spezial:Weblinksuche/http://wikimedia.org to https://de.wikipedia.org/wiki/Spezial:Weblinksuche/https://wikimedia.org instead of https://de.wikipedia.org/wiki/Spezial:Weblinksuche/http://wikimedia.org Bug: 63573 Change-Id: Ife5099c3c5a0e943bb08b81be5d5669d0e02be17
* Fixed some @params documentation (includes/*)umherirrender2014-04-201-7/+7
| | | | | | | | | Swapped some "$var type" to "type $var" or added missing types before the $var. Changed some other types to match the more common spelling. Makes beginning of some text in captial. Also added some missing @param. Change-Id: I7f605aa9e117b5fd80d9b1440864fe526d2b14a5
* Merge "Avoid site outages due to broken job queues"jenkins-bot2014-04-151-2/+7
|\
| * Avoid site outages due to broken job queuesAaron Schulz2014-04-111-2/+7
| | | | | | | | Change-Id: I71f1bef886850679812e23b8a49fc9b80d9b6102
* | Commit DB changes as normal on exception-based GUI errorsAaron Schulz2014-04-141-1/+9
|/ | | | | Bug: 62091 Change-Id: I36cd645d5f7a939b60f306e5fc093507693b097b
* Avoid making a derivative request to Special:RunJobs when the job queue is emptyAaron Schulz2014-04-091-0/+4
| | | | | | | | | | | Checking that the job queue is nonempty is cheap, and when the result is negative (that is, when the queue is actually empty), it spares from having to launch a derivative request to Special:RunJobs for job processing. The derivative request is not cheap, because processing it requires having an additional full instance of the application. This patch adds the check. Bug: 60210 Change-Id: Icb95c35f4a8a3c9d4b5aff97fdfabf596d05940a
* Added $wgRunJobsAsync to allow running jobs the old wayJesús Martínez Novo2014-04-091-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding a new global variable (DefaultSettings.php) named $wgRunJobsAsync, that defaults to true, to allow installations to force the old synchronous job execution on page requests instead of the new asynchonous one. The asynchronous job queue execution was added in 1.22, executing a new shell script, and it caused major problems for third party installations with restricted environments or limited system resources, and also because a lot of bugs that went unnoticed because WMF wikis do not use the on-request job queue. In 1.23 it was changed to use a new internal HTTP request to a MediaWiki entry point to perform the request, While some of the bugs were solved, it could still have performance problems for opening a new process and loading a lot of MediaWiki PHP objects on it, just to perform a request to see if there are pending jobs and execute them (it doesn't check if there are jobs to execute). While this may improve speed on single page requests, because it does not block the execution of the current page, it has't been thoroughly tested on third party installations. And what is more important, now there's no way to revert back to the old way of handling those jobs, as it was done in 1.22 (setting $wgPhpCli = false). This means, in case of major bugs on the job queue execution due to the new request, there's no way to fix it other than editing MediaWiki PHP files directly, or completely disable the on-request job queue handling (some hosts can't set up a cron job for that) This situation makes it critical to have a safe way to revert to the old job queue handling, at least until testing that the current implementation doesn't break a lot of installations. Bug: 61387 Change-Id: I892a3608228ec0a1c63268fb6180ec679c315980
* Reduce connect timeout in MediaWiki::triggerJobsErik Bernhardson2014-03-251-1/+4
| | | | | | | | | | | | The fifth parameter to fsockopen is the number of seconds to wait before declaring the connection a failure. When not provided it defaults to the php ini value of 'default_socket_timeout' which is 60s. Under no circumstances should we wait 60s to connect to ourselves, 100ms seems like a reasonable timeout since its explicitly connecting to itself, but the exact timeout could be slightly longer. Change-Id: I18d328274ddf1e0848fce40ebf39e0466b5c4d5d
* Avoid header notice log spam from RunJobs APIAaron Schulz2014-03-181-11/+7
| | | | | | | | | | * Moved ApiRunJobs to a special page instead of going through ApiMain and having to fight the logic there. As a separate internal API, this does not show up on the API help page and is no longer effected by $wgEnableAPI. bug: 62233 Change-Id: I1db6f526d02e130a66ee03289858a734d89e6c00
* Call ignore_user_abort() right before committing to the DBAaron Schulz2014-03-121-0/+3
| | | | Change-Id: I48b9e90418c38c7c9970cf0739a877b5be3a2b64
* Have ApiRunJobs run periodic tasksNik Everett2014-03-071-2/+4
| | | | | | | | Without this apirunjobs can't handle delayed jobs. Small inline comment updates as well. Change-Id: I85ba0ac99eaebc16eaa7e2eb7019546241f3149c
* Avoid API error/header leakage from jobs APIAaron Schulz2014-02-281-9/+3
| | | | | | | * Also cleaned up some HTTP headers while at it bug: 62092 Change-Id: Ia2c1643e47aae53916c107c901cca654dc438a16
* Handle some extra cases in triggerJobs()Aaron Schulz2014-02-281-2/+16
| | | | | | | | | | | * $wgEnableAPI may be false, though it is a basic part of MediaWiki. This only disables api.php and not internal callers so just do that. * Various socket functions may disabled. Though this is a terrible wack-a-mole security measure to handle MediaWiki exploits or non-authenticated services, it may still be in use, so work around it. Change-Id: I54a209e003ffce1fe36a5898fe0da735cf5e32e4
* Moved job running via $wgJobRunRate to a special APIAaron Schulz2014-02-271-49/+42
| | | | | | | | | | | | | | | | | | | | * A background internal HTTP request used to load the API. This handles job execution and related periodic tasks. It avoids blocking the main request or breaking it on fatals. * This method avoids problems that shelling could have: ** Mismatched apache/cli PHP config or versions. ** Had to start a new process and could not use opcode cache. ** safe_mode and open_basedir restrictions required a fallback. ** Some wiki farms may not respect the --wiki parameter. ** wgMaxShellMemory applies to spawned PHP processes. ** Spawning processes is more prone to DOS due to a lack of proper limiting/pooling. bug: 60208 bug: 60210 bug: 60698 bug: 60844 Change-Id: I78b0e709301ac4a0c7b7ed337d6969d7546674bf
* Added --wiki parameter to runJobs.php callAaron Schulz2014-02-071-1/+2
| | | | Change-Id: I8f729263397bedf1c293b14704798e7a4ec60581
* Various fixes to job running code in Wiki.phpAaron Schulz2014-01-291-3/+10
| | | | | | | | | | * Make it async on Windows * Fixed possible "invalid filename" errors on Windows * Redirect output to dev/null to avoid hanging PHP bug: 60231 bug: 58719 Change-Id: If4e52b86fb3a1bff283dfba3dfac213367f47543
* Remove deprecated MediaWiki::articleFromTitle() and WikiPage::createUpdates()Siebrand Mazeland2014-01-221-13/+0
| | | | | | | | | No uses found in core or Gerrit extensions. * MediaWiki::articleFromTitle() (deprecated in 1.18) * WikiPage::createUpdates() (deprecated in 1.18) Change-Id: I689249b579ee89f883b97fdb4ac79fb3502c45dc
* Merge "Don't convert bad curids to the Main Page"jenkins-bot2014-01-041-1/+1
|\
| * Don't convert bad curids to the Main PageJackmcbarn2014-01-021-1/+1
| | | | | | | | | | | | | | | | When a curid that doesn't exist is requested, cause the "Bad title" error to be displayed rather than displaying the Main Page. Bug: 58885 Change-Id: If54ca35b3799b8cf2f76e7f8a03001caa1fac676
* | Merge "Add fastcgi_finish_request where appropriate"jenkins-bot2014-01-031-0/+3
|\ \
| * | Add fastcgi_finish_request where appropriateTyler Anthony Romeo2014-01-031-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using PHP-FPM to run PHP on a web server, the function fastcgi_finish_request is provided, which flushes all response data to the client and closes the connection, allowing PHP to perform additional work without delaying the client. This adds fastcgi_finish_request calls in index.php and api.php where appropriate and if the function exists, so that the connection is closed once the output is definitely finished. Change-Id: Ic67a8956545874e94df5198088c0f4aa58ca376e
* | | Change Title::getInterwiki() in conditions to Title::isExternal()umherirrender2014-01-021-3/+3
| |/ |/| | | | | Change-Id: Icce26e6194ae96f262029554e05b49117d5e112e
* | Move closing parenthesis from multi line if and function to own lineumherirrender2013-12-011-18/+18
|/ | | | | | | | | | | The Line continuation Coding conventions prefers the closing parenthesis on the same line than the beginning curly braces. This is done for ifs and functions. Also move some boolean operator from the end of a line to the beginning and changed some indentation to make the condition hopefully better readable. Change-Id: Id0437b06bde86eb5a75bc59eefa19e7edb624426
* Introduce WebRequest::getProtocol()Tim Starling2013-11-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | The use of static server detection outside of its intended use case (i.e. at the start of DefaultSettings.php), for example in r93258, was an architectural error. Every other bit of information about the web request in non-setup code comes from non-static methods of WebRequest, which allows the request object to be meaningfully replaced or subclassed. The situation became increasingly ridiculous as more callers of WebRequest::detectProtocol() were introduced. Two of the callers were calling it non-statically! I suppose they had the right idea, in a way. Using a non-static call allows caching, which is a nice additional benefit. WebRequest::detectProtocolAndStdPort() was introduced in r93258 as part of the introduction of WebRequest::detectProtocol(). It was basically useless. Grep indicates there was only one caller in core and WMF deployed extensions, and it is patched here. Change-Id: Ia0a61e98fbff7a46ceaeebcb02236e5eac3df0e1
* Kill $wgArticleChad Horohoe2013-11-011-7/+0
| | | | | | | | | | | | | | | | | | | This has been deprecated since 1.18, throwing warnings for over a year and a half now, and nothing uses it anywhere in core or deployed extensions. No extensions in SVN seem to have this anymore (we must've cleaned up well), and the only affected extensions in Git are: - BlueSpiceExtensions - DynamicPageList (commented, so shouldn't be a worry) - SemanticPageMaker - TwitterCards If you're the author of one of these extensions or are feeling like cleaning up ancient code, please get them fixed. Change-Id: I8f3a54c14be4b38a8b917e32ba3a832e0a7ca116
* exception: Use MWExceptionHandler::logException in more placesTimo Tijhof2013-10-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most code replaced wasn't exactly like what logException does but most probably should be. A few implementation differences with the code it replaced in various places: * MWException if-guards Was there only to prevent a crash because getLogMessage is an MWException method. Now that logException is generic, it seems sensible to start logging those as well (follows-up a97f3550a0). * Exception::getTraceAsString Now using MWExceptionHandler::formatRedactedTrace instead. It wasn't using it because that method didn't exist yet. Notes: * DatabaseError::getLogMessage Removed as this override was no longer doing anything (we're using MWExceptionHandler::getLogMessage instead of $e->getLogMessage). Introduced isLoggable() to take over the responsibility of indicating when an exception should not be logged (follows-up bcb9f9e1c0d). * DeferredUpdates and Wiki.php Both specificy MWException. Though ApiMain intends to catch all and only logged MWException because it couldn't otherwise, these actually only catch MWException (as opposed to catching all and having an if-statement inside). Left those as-is to have them continue propagate other exceptions. * JobQueueFederated and JobQueueGroup All specify to catch JobQueueError only. Not sure whether it should catch other exceptions. It now can, but I'll leave it as is in case it intends to have those be handled elsewhere (or fatal). Change-Id: I4578a0fe7d95a080f1a3b292ce7ae73a4d5fcaca
* Correctly update wl_notificationtimestamp when viewing old revisionsBartosz Dziewoński2013-10-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | == Prelude == wl_notificationtimestamp controls sending the user e-mail notifications about changes to pages, as well as showing the "updated since last visit" markers on history pages, recent changes and watchlist. == The bug == Previously, on every view of a page, the notification timestamp was cleared, regardless of whether the user as actually viewing the latest revision. When viewing a diff, however, the timestamp was cleared only if one of the revisions being compared was the latest one of its page. The same behavior applied to talk page message indicators (which are actually stored sepately to cater to anonymous users). This was inconsistent and surprising when one was attempting to, say, go through the 50 new posts to a discussion page in a peacemeal fashion. == The fix == If the revision being viewed is the latest (or can't be determined), the timestamp is cleared as previously, as this is necessary to reenable e-mail notifications for given user and page. If the revision isn't the latest, the timestamp is updated to revision's timestamp plus one second. This uses up to two simple (selectField) indexed queries per page view, only fired when we do not already know we're looking at the latest version. Talk page indicator is updated to point at the next revision after the one being viewed, or cleared if viewing the latest revision. The UserClearNewTalkNotification hook gained $oldid as the second argument (a backwards-compatible change). In Skin, we no longer ignore the indicator being present if we're viewing the talk page, as it might still be valid. == The bonus == Comments and formatting was updated in a few places, including tables.sql and Wiki.php. The following functions gained a second, optional $oldid parameter (holy indirection, Batman!): * WikiPage#doViewUpdates() * User#clearNotification() * WatchedItem#resetNotificationTimestamp() DifferenceEngine gained a public method mapDiffPrevNext() used to parse the ids from URL parameters like oldid=12345&diff=prev, factored out of loadRevisionIds(). A bug where the NewDifferenceEngine hook would not be called in some cases, dating back to its introduction in r45518, was fixed in the process. Bug: 41759 Change-Id: I4144ba1987b8d7a7e8b24f4f067eedac2ae44459
* Move forceHTTPS check until after wgTitle is setupcsteipp2013-10-071-20/+22
| | | | | | | | | | | Since the forceHTTPS logic checks if the user is logged in, which calls all sorts of hooks, some that assume that $wgTitle is setup (like AbuseFilter for preventing autocreation of usernames), move the logic down a few lines. Bug: 55435 Bug: 53498 Change-Id: I53c82921595a9014b555e4ec468e5ba10454cd3a
* Merge "Add Vary: X-Forwarded-Proto for https redirects"jenkins-bot2013-10-011-0/+2
|\
| * Add Vary: X-Forwarded-Proto for https redirectscsteipp2013-09-301-0/+2
| | | | | | | | | | | | | | | | From mark's comments on https://gerrit.wikimedia.org/r/#/c/86268/, we should be setting Vary: X-Forwarded-Proto when the response varies on the protocol, which is the case for redirects from http->https. Change-Id: Ie6dc9da4e804199b99e3a7abbea7775a181801a0
* | Move 'main page as default title' further down to unbreak diff urlsNiklas Laxström2013-09-301-4/+11
|/ | | | | | | | | | | | The feature that oldid and diff parameters override the title was not working if wiki's main page is a special page, because that behaviour was excluded for special pages. Hence moved the main page as default title code further down, so that we will hit the no title provided condition for the oldid and diff parameter only links. Bug: 54452 Change-Id: I62cc6e2568a4db988fcf113955ba02710e42a1d2
* Pass context to Action::factoryaude2013-09-191-1/+2
| | | | | | | Fixes a PHP Notice that was introduced on every page (follows-up 01d81d88) Bug: 54344 Change-Id: I24f01c7244089e73b0cf2e0af37c365f9dd051b2
* Also redirect if prefixed https cookie is presetcsteipp2013-08-301-0/+2
| | | | | | | | After we switch to not using prefixes, still respect prefixed cookies for users who are currently logged in. Bug: 53538 Change-Id: I950e36e10420209fca28c41c438c363a3f332c14
* Remove prefix from forceHTTPS cookiecsteipp2013-08-291-1/+1
| | | | | | | Match CentralAuth, and set appropriate expiration too. Bug: 53538 Change-Id: I3c16ff92781e1a72346058ae3838d8fc47019d55
* Core support for disabling HTTPS based on GeoIPTim Starling2013-08-211-1/+4
| | | | | | | | | | | | | | | * Introduce a hook allowing automatic redirects to HTTPS to be disabled on the basis of client IP address. * Make User::requiresHTTPS() return false if the client IP is blacklisted as such. * On login, make the "stick HTTPS" option default to false if the client IP address is blacklisted as such. * Do not redirect anonymous requests to HTTPS. * If $wgSecureLogin is enabled, link to the HTTPS login page *via* the HTTP redirect, so that there is no need to vary the cache of anonymous page view HTML on client IP address. Change-Id: Iaa9dd2108431b8c35e05db4bfe78a629018a003c
* Fix super long lineChad Horohoe2013-08-191-1/+2
| | | | Change-Id: Ib76a2b6209137bcf18db9b756fa7406547611129
* Add some logging for weird redirected POSTsChad Horohoe2013-08-191-2/+14
| | | | Change-Id: Ib19ebc2306e85fdb8c29b5850f2306bec7907938
* Change secure login to use a user preferenceTyler Anthony Romeo2013-08-191-3/+10
| | | | | | | | | | Removed the wpStickHTTPS checkbox from the login form, and instead just use the user's preferences along with whether they came from HTTPS or not to determine if they should stay in HTTPS. Bug: 29898 Bug: 52283 Change-Id: I69e9cb23b8d700e821b8a961c672958e4e19e4f8
* Hide exceptions in MediaWiki::doJobs() as deferred updates do.Aaron Schulz2013-05-141-20/+27
| | | | Change-Id: Ia83029d4c06bf3f2be6ad0797e815464e44fd088
* Pass array to Title::getLocalURL instead of an urlencoded stringumherirrender2013-04-271-1/+1
| | | | | | | This makes code easier to read and the urlencode is done inside getLocalURL or friends Change-Id: I21b988890356d11835eedba12a90a347bf0905b2
* Changed on-request job running to shell out instead of doing a loop.Aaron Schulz2013-04-251-20/+31
| | | | | | | | | | | | * Also factored out a new wfShellExecDisabled() function. * This will keep the process in the background if possible to avoid killing site performance, especially with slow jobs. * This also keep fatals and uncatcheable exceptions from hitting the user. * If $wgPhpCli is not set to an actual path or safe mode is on, then the old code will be used. Change-Id: I6a28152251659ee53eee2604f16d5bf02c85a44f
* Fixed spacing in files direct in includes folderumherirrender2013-04-211-2/+2
| | | | | | | Added spaces before if, foreach Added some braces for one line statements Change-Id: Ibb8dd102db045522d12ff939075ba7420d95ab6b
* Wrap job execution around profiling calls.Aaron Schulz2013-04-181-1/+3
| | | | Change-Id: Idf184b7c2f7003032d3a28830ee9c4a1eaeaa98b
* Correct case of Title::getPrefixedDBkey() callsAlexandre Emsenhuber2013-03-091-1/+1
| | | | Change-Id: Ic9ef0cc6dbb0a8eb0ee93432299ef59759223e2c
* fix some spacingumherirrender2013-03-071-4/+4
| | | | | | | | Added/removed spaces around logical/arithmetic operator Reduced multiple empty lines to one empty line Removed wrong tabs before comments at end of line Removed too many spaces in assigments Change-Id: I2bba4e72f9b5f88c53324d7b70e6042f1aad8f6b
* fix some spacingumherirrender2013-01-271-2/+2
| | | Change-Id: Ie7bb35871cc99237f3a655f7db22ca1f0646df5e
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-22 18:15:34 +0000