aboutsummaryrefslogtreecommitdiffstats
path: root/includes/ResourceLoader/ImageModule.php
Commit message (Collapse)AuthorAgeFilesLines
* Remove 2-line PHPDocs that just repeat the types from the codethiemowmde2025-01-171-4/+0
| | | | | | | | | | | | | | | | Same as Ia294bf4 did for 1-line comments. This patch removes slightly more complex 2-line PHPDoc comments that don't add any new information to the code, but literally repeat what the code already says. They say "don't document the code, code the documentation", and we are doing this more and more. We just tend to forget to remove the obsolete comments. Note I'm also removing a line of text in a few cases when it's very short and literally says the same as the method name. Again, such comments add zero new information. Change-Id: I01535404bab458c6c47e48e5456403b7a64198ed
* resourceloader: Add/change ResourceLoaderModifyEmbeddedSourceUrls hookBartosz Dziewoński2024-09-271-1/+9
| | | | | | | | | | We've discovered some new requirements. Follow-up to 31f614f7322c1e050eba0a91aa339e3cc495b8a1. The hook was not in a release yet, so we can rename it. Bug: T371530 Change-Id: I82d8ae69c27a38c45eab5d19c063f0b9515b8ec8
* ResourceLoader: Add missing documentation to class propertiesUmherirrender2024-09-071-0/+4
| | | | | | | | | | Add doc-typehints to class properties found by the PropertyDocumentation sniff to improve the documentation. Once the sniff is enabled it avoids that new code is missing type declarations. This is focused on documentation and does not change code. Change-Id: I90ecf85cb6f639af4be1947ccfbfb16d5b84cab3
* Fix typo in browser vendor prefixJon Robson2024-09-051-1/+1
| | | | | | This is preventing icons from displaying in older Chrome browsers Change-Id: I017da77ccda5763dc0312859127c453ba69e4029
* Support mask-image in ResourceLoader ImageModuleJon Robson2024-07-171-0/+20
| | | | | | | | | | | | | | The feature would be opt in to retain backwards compatible support while also moving closer to rendering icons consistently with how Codex does. An example of this in use are: * Ie5c88e0aa243f73f2dc9f310d18fd59b831edc64 * I17fabdf276f6c33fb78c007d75cda6bb9e02d79b Bug: T365764 Bug: T358246 Change-Id: I95caab8037ccceba73101da2eb3c601f39511377
* Drop old ResourceLoader class aliases, deprecated since 1.39James D. Forrester2024-01-311-3/+0
| | | | | | | Depends-On: Iff15a2e13a3507ef1ab5cfa504ca1a1c8d2b2a60 Depends-On: Icf8331e35acf6fe51a8303ee639921b9e4f3e6bb Depends-On: I5a5af003026db69b279ddde0b0dedbfcfe7d70fd Change-Id: I5929a2f760c8d21c1cb2542a19220a91ac7240e4
* ResourceLoaderImageModule::getCssDeclarations: Tweak doc explanationJames D. Forrester2023-07-131-1/+1
| | | | | | | | There's no optionality here, which is what we normally mean by 'default'; if users wanted an alternative, they'd have to sub-class. Follows-Up: I32209b5c7628eea874dc0dbdb0bb361098fd2da8 Change-Id: I946626371c63b82df58ea7d075259676a3f5134d
* ResourceLoader: Remove unused rasterized URL in ImageModule::getCssDeclarationsTimo Tijhof2023-07-131-7/+4
| | | | | | | | | | The code appeared such that `getUrl(,'rasterized')` is still in active use and somehow exposed, but it wasn't. Remove it as such, since the parameter isn't used. Bug: T329127 Bug: T321394 Change-Id: I32209b5c7628eea874dc0dbdb0bb361098fd2da8
* ResourceLoader: tweak comments and error messagesTim Starling2023-04-031-1/+1
| | | | Change-Id: Ifcaefedf65b090a87ec1417808277ae6451302dc
* ResourceLoader: Remove SVG fallback hack from ImageModuleBartosz Dziewoński2023-02-081-10/+4
| | | | | Bug: T329127 Change-Id: I0bf50e2d2e0a3ba0ba4c8fceb19cd2ae96d8d9fb
* ResourceLoader: Define targets in a single locationKosta Harlan2023-02-021-1/+0
| | | | | | | | | All the *Module classes end up inheriting from ResourceLoader/Module, so we only need to define the targets there. Bug: T127268 Bug: T328497 Change-Id: I12b126377cea78b88269e6efe68f92f3586c4ecc
* Make use of ?:, ?? and ??= operators in mostly trivial casesthiemowmde2022-12-051-5/+1
| | | | | | | | | | The motivation is to make the code less confusing. I hope this is the case. ?? is an older PHP 7.0 feature. ??= was added in PHP 7.4, which we can finally use. Change-Id: Id807affa52bd1151a74c064623b41d950a389560
* Remove unused key variable from foreach loopsUmherirrender2022-09-211-2/+2
| | | | Change-Id: Id2d91e30a6f7cc4eb93427b50efc1c5c77f14b75
* ResourceLoader: Remove unchecked exception annotationsAdam Wight2022-06-221-1/+0
| | | | | | | | Also repair two `@see` annotations referring to methods that didn't exist. Bug: T240672 Change-Id: I2edb39554bcf46fdc83bd138ef7bb9065c2c0696
* ResourceLoader namespace (attempt 2)Tim Starling2022-05-241-0/+504
| | | | | | | | | | | | | | | | | | Move ResourceLoader classes to their own namespace. Strip the "ResourceLoader" prefix from all except ResourceLoader itself. Move the tests by analogy. I used a namespace alias "RL" in some callers since RL\Module is less ambiguous at the call site than just "Module". I did not address DependencyStore which continues to have a non-standard location and namespace. Revert of a241d83e0a6dabedf. Bug: T308718 Change-Id: Id08a220e1d6085e2b33f3f6c9d0e3935a4204659
* Revert "ResourceLoader namespace"Lucas Werkmeister (WMDE)2022-05-161-504/+0
| | | | | | | | | | | | This reverts commit e08ea8ccb9932f9924a613056afcb2d01c8c7b39. Reason for revert: Breaks Phan in extensions, and as far as I’m aware, this change isn’t urgently needed for anything, so the simplest fix is to revert it again for now. After PHP 7.4 it should be safer to try this again (we hopefully won’t need the two “hack” classes by then). Bug: T308443 Change-Id: Iff3318cbf97a67f821f78e60da62a583f63e389e
* ResourceLoader namespaceTim Starling2022-05-161-0/+504
Move ResourceLoader classes to their own namespace. Strip the "ResourceLoader" prefix from all except ResourceLoader and ResourceLoaderContext. Move the tests by analogy. I used a namespace alias "RL" in some callers since RL\Module is less ambiguous at the call site than just "Module". I did not address DependencyStore which continues to have a non-standard location and namespace. Change-Id: I92998ae6a82e0b935c13e02a183e7c324fa410a3
generated by cgit v1.2.3 (git 2.25.1) at 2025-04-29 11:50:57 +0000