diff options
66 files changed, 219 insertions, 219 deletions
diff --git a/includes/specials/SpecialAllPages.php b/includes/specials/SpecialAllPages.php index 6f0960f0fa82..078b67aab8ba 100644 --- a/includes/specials/SpecialAllPages.php +++ b/includes/specials/SpecialAllPages.php @@ -46,7 +46,7 @@ class SpecialAllPages extends IncludableSpecialPage { /** * @param string $name Name of the special page, as seen in links and URLs (default: 'Allpages') */ - function __construct( $name = 'Allpages' ) { + public function __construct( $name = 'Allpages' ) { parent::__construct( $name ); } @@ -55,7 +55,7 @@ class SpecialAllPages extends IncludableSpecialPage { * * @param string $par Becomes "FOO" when called like Special:Allpages/FOO (default null) */ - function execute( $par ) { + public function execute( $par ) { $request = $this->getRequest(); $out = $this->getOutput(); diff --git a/includes/specials/SpecialAncientPages.php b/includes/specials/SpecialAncientPages.php index c85ddd66c8d5..973521fb2111 100644 --- a/includes/specials/SpecialAncientPages.php +++ b/includes/specials/SpecialAncientPages.php @@ -30,7 +30,7 @@ use MediaWiki\MediaWikiServices; */ class SpecialAncientPages extends QueryPage { - function __construct( $name = 'Ancientpages' ) { + public function __construct( $name = 'Ancientpages' ) { parent::__construct( $name ); } @@ -38,7 +38,7 @@ class SpecialAncientPages extends QueryPage { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } @@ -76,7 +76,7 @@ class SpecialAncientPages extends QueryPage { return true; } - function sortDescending() { + protected function sortDescending() { return false; } @@ -89,7 +89,7 @@ class SpecialAncientPages extends QueryPage { * @param object $result Result row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $d = $this->getLanguage()->userTimeAndDate( $result->value, $this->getUser() ); $title = Title::makeTitle( $result->namespace, $result->title ); $linkRenderer = $this->getLinkRenderer(); diff --git a/includes/specials/SpecialBotPasswords.php b/includes/specials/SpecialBotPasswords.php index 6059cea28393..4d406137b6da 100644 --- a/includes/specials/SpecialBotPasswords.php +++ b/includes/specials/SpecialBotPasswords.php @@ -66,7 +66,7 @@ class SpecialBotPasswords extends FormSpecialPage { * Main execution point * @param string|null $par */ - function execute( $par ) { + public function execute( $par ) { $this->getOutput()->disallowUserJs(); $this->requireLogin(); $this->addHelpLink( 'Manual:Bot_passwords' ); diff --git a/includes/specials/SpecialBrokenRedirects.php b/includes/specials/SpecialBrokenRedirects.php index 4484c0bd579d..140246b8bccd 100644 --- a/includes/specials/SpecialBrokenRedirects.php +++ b/includes/specials/SpecialBrokenRedirects.php @@ -32,7 +32,7 @@ use Wikimedia\Rdbms\IResultWrapper; * @ingroup SpecialPage */ class SpecialBrokenRedirects extends QueryPage { - function __construct( $name = 'BrokenRedirects' ) { + public function __construct( $name = 'BrokenRedirects' ) { parent::__construct( $name ); } @@ -40,15 +40,15 @@ class SpecialBrokenRedirects extends QueryPage { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } - function sortDescending() { + protected function sortDescending() { return false; } - function getPageHeader() { + protected function getPageHeader() { return $this->msg( 'brokenredirectstext' )->parseAsBlock(); } @@ -91,7 +91,7 @@ class SpecialBrokenRedirects extends QueryPage { /** * @return array */ - function getOrderFields() { + protected function getOrderFields() { return [ 'rd_namespace', 'rd_title', 'rd_from' ]; } @@ -100,7 +100,7 @@ class SpecialBrokenRedirects extends QueryPage { * @param object $result Result row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $fromObj = Title::makeTitle( $result->namespace, $result->title ); if ( isset( $result->rd_title ) ) { $toObj = Title::makeTitle( $result->rd_namespace, $result->rd_title, $result->rd_fragment ); @@ -179,7 +179,7 @@ class SpecialBrokenRedirects extends QueryPage { * @param IDatabase $db * @param IResultWrapper $res */ - function preprocessResults( $db, $res ) { + public function preprocessResults( $db, $res ) { $this->executeLBFromResultWrapper( $res ); } diff --git a/includes/specials/SpecialChangeEmail.php b/includes/specials/SpecialChangeEmail.php index ca24a500e1bf..b131bb0e777c 100644 --- a/includes/specials/SpecialChangeEmail.php +++ b/includes/specials/SpecialChangeEmail.php @@ -55,7 +55,7 @@ class SpecialChangeEmail extends FormSpecialPage { * Main execution point * @param string $par */ - function execute( $par ) { + public function execute( $par ) { $out = $this->getOutput(); $out->disallowUserJs(); diff --git a/includes/specials/SpecialConfirmEmail.php b/includes/specials/SpecialConfirmEmail.php index 82d9564430c3..7c35faafaaba 100644 --- a/includes/specials/SpecialConfirmEmail.php +++ b/includes/specials/SpecialConfirmEmail.php @@ -48,7 +48,7 @@ class SpecialConfirmEmail extends UnlistedSpecialPage { * @throws ReadOnlyError * @throws UserNotLoggedIn */ - function execute( $code ) { + public function execute( $code ) { // Ignore things like master queries/connections on GET requests. // It's very convenient to just allow formless link usage. $trxProfiler = Profiler::instance()->getTransactionProfiler(); diff --git a/includes/specials/SpecialDeadendPages.php b/includes/specials/SpecialDeadendPages.php index 9159442be33f..bf90070b7a66 100644 --- a/includes/specials/SpecialDeadendPages.php +++ b/includes/specials/SpecialDeadendPages.php @@ -30,11 +30,11 @@ use MediaWiki\MediaWikiServices; */ class SpecialDeadendPages extends PageQueryPage { - function __construct( $name = 'Deadendpages' ) { + public function __construct( $name = 'Deadendpages' ) { parent::__construct( $name ); } - function getPageHeader() { + protected function getPageHeader() { return $this->msg( 'deadendpagestext' )->parseAsBlock(); } @@ -43,22 +43,22 @@ class SpecialDeadendPages extends PageQueryPage { * * @return bool */ - function isExpensive() { + public function isExpensive() { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } /** * @return bool */ - function sortDescending() { + protected function sortDescending() { return false; } - function getQueryInfo() { + public function getQueryInfo() { return [ 'tables' => [ 'page', 'pagelinks' ], 'fields' => [ @@ -81,7 +81,7 @@ class SpecialDeadendPages extends PageQueryPage { ]; } - function getOrderFields() { + protected function getOrderFields() { // For some crazy reason ordering by a constant // causes a filesort if ( count( MediaWikiServices::getInstance()->getNamespaceInfo()-> diff --git a/includes/specials/SpecialDeletedContributions.php b/includes/specials/SpecialDeletedContributions.php index ed9b3e1d3dbf..b85a22d66bd2 100644 --- a/includes/specials/SpecialDeletedContributions.php +++ b/includes/specials/SpecialDeletedContributions.php @@ -33,7 +33,7 @@ class SpecialDeletedContributions extends SpecialPage { /** @var FormOptions */ protected $mOpts; - function __construct() { + public function __construct() { parent::__construct( 'DeletedContributions', 'deletedhistory' ); } @@ -43,7 +43,7 @@ class SpecialDeletedContributions extends SpecialPage { * * @param string $par (optional) user name of the user for which to show the contributions */ - function execute( $par ) { + public function execute( $par ) { $this->setHeaders(); $this->outputHeader(); $this->checkPermissions(); diff --git a/includes/specials/SpecialDoubleRedirects.php b/includes/specials/SpecialDoubleRedirects.php index a09d67052ff7..9d39f545a20b 100644 --- a/includes/specials/SpecialDoubleRedirects.php +++ b/includes/specials/SpecialDoubleRedirects.php @@ -32,7 +32,7 @@ use Wikimedia\Rdbms\IResultWrapper; * @ingroup SpecialPage */ class SpecialDoubleRedirects extends QueryPage { - function __construct( $name = 'DoubleRedirects' ) { + public function __construct( $name = 'DoubleRedirects' ) { parent::__construct( $name ); } @@ -40,15 +40,15 @@ class SpecialDoubleRedirects extends QueryPage { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } - function sortDescending() { + protected function sortDescending() { return false; } - function getPageHeader() { + protected function getPageHeader() { return $this->msg( 'doubleredirectstext' )->parseAsBlock(); } @@ -107,7 +107,7 @@ class SpecialDoubleRedirects extends QueryPage { return $this->reallyGetQueryInfo(); } - function getOrderFields() { + protected function getOrderFields() { return [ 'ra.rd_namespace', 'ra.rd_title' ]; } @@ -116,7 +116,7 @@ class SpecialDoubleRedirects extends QueryPage { * @param object $result Result row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { // If no Title B or C is in the query, it means this came from // querycache (which only saves the 3 columns for title A). // That does save the bulk of the query cost, but now we need to @@ -214,7 +214,7 @@ class SpecialDoubleRedirects extends QueryPage { * @param IDatabase $db * @param IResultWrapper $res */ - function preprocessResults( $db, $res ) { + public function preprocessResults( $db, $res ) { if ( !$res->numRows() ) { return; } diff --git a/includes/specials/SpecialEmailInvalidate.php b/includes/specials/SpecialEmailInvalidate.php index 7b9ee1a4fed5..7b681dd57e08 100644 --- a/includes/specials/SpecialEmailInvalidate.php +++ b/includes/specials/SpecialEmailInvalidate.php @@ -36,7 +36,7 @@ class SpecialEmailInvalidate extends UnlistedSpecialPage { return true; } - function execute( $code ) { + public function execute( $code ) { // Ignore things like master queries/connections on GET requests. // It's very convenient to just allow formless link usage. $trxProfiler = Profiler::instance()->getTransactionProfiler(); diff --git a/includes/specials/SpecialFewestRevisions.php b/includes/specials/SpecialFewestRevisions.php index b4dd62a3004c..d6652d07304a 100644 --- a/includes/specials/SpecialFewestRevisions.php +++ b/includes/specials/SpecialFewestRevisions.php @@ -38,7 +38,7 @@ class SpecialFewestRevisions extends QueryPage { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } @@ -62,7 +62,7 @@ class SpecialFewestRevisions extends QueryPage { ]; } - function sortDescending() { + protected function sortDescending() { return false; } @@ -71,7 +71,7 @@ class SpecialFewestRevisions extends QueryPage { * @param object $result Database row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $nt = Title::makeTitleSafe( $result->namespace, $result->title ); if ( !$nt ) { return Html::element( diff --git a/includes/specials/SpecialFileDuplicateSearch.php b/includes/specials/SpecialFileDuplicateSearch.php index 029f49aea0a5..830c7448b64f 100644 --- a/includes/specials/SpecialFileDuplicateSearch.php +++ b/includes/specials/SpecialFileDuplicateSearch.php @@ -39,15 +39,15 @@ class SpecialFileDuplicateSearch extends QueryPage { */ protected $file = null; - function __construct( $name = 'FileDuplicateSearch' ) { + public function __construct( $name = 'FileDuplicateSearch' ) { parent::__construct( $name ); } - function isSyndicated() { + public function isSyndicated() { return false; } - function isCacheable() { + public function isCacheable() { return false; } @@ -205,7 +205,7 @@ class SpecialFileDuplicateSearch extends QueryPage { * @param File $result * @return string HTML */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $linkRenderer = $this->getLinkRenderer(); $nt = $result->getTitle(); $text = MediaWikiServices::getInstance()->getContentLanguage()->convert( diff --git a/includes/specials/SpecialImport.php b/includes/specials/SpecialImport.php index 2371e6f4c424..1ddeb71cedcf 100644 --- a/includes/specials/SpecialImport.php +++ b/includes/specials/SpecialImport.php @@ -69,7 +69,7 @@ class SpecialImport extends SpecialPage { * @throws PermissionsError * @throws ReadOnlyError */ - function execute( $par ) { + public function execute( $par ) { $this->useTransactionalTimeLimit(); $this->setHeaders(); diff --git a/includes/specials/SpecialLinkSearch.php b/includes/specials/SpecialLinkSearch.php index fe2baf5aeb5a..209370ac5516 100644 --- a/includes/specials/SpecialLinkSearch.php +++ b/includes/specials/SpecialLinkSearch.php @@ -45,7 +45,7 @@ class SpecialLinkSearch extends QueryPage { $this->mProt = $params['protocol']; } - function __construct( $name = 'LinkSearch' ) { + public function __construct( $name = 'LinkSearch' ) { parent::__construct( $name ); // Since we don't control the constructor parameters, we can't inject services that way. @@ -53,7 +53,7 @@ class SpecialLinkSearch extends QueryPage { // using the setServices() method. } - function isCacheable() { + public function isCacheable() { return false; } @@ -148,7 +148,7 @@ class SpecialLinkSearch extends QueryPage { * Disable RSS/Atom feeds * @return bool */ - function isSyndicated() { + public function isSyndicated() { return false; } @@ -215,7 +215,7 @@ class SpecialLinkSearch extends QueryPage { * @param IDatabase $db * @param IResultWrapper $res */ - function preprocessResults( $db, $res ) { + public function preprocessResults( $db, $res ) { $this->executeLBFromResultWrapper( $res ); } @@ -224,7 +224,7 @@ class SpecialLinkSearch extends QueryPage { * @param object $result Result row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $title = new TitleValue( (int)$result->namespace, $result->title ); $pageLink = $this->getLinkRenderer()->makeLink( $title ); @@ -239,7 +239,7 @@ class SpecialLinkSearch extends QueryPage { * Not much point in descending order here. * @return array */ - function getOrderFields() { + protected function getOrderFields() { return []; } diff --git a/includes/specials/SpecialListDuplicatedFiles.php b/includes/specials/SpecialListDuplicatedFiles.php index 2bcc82e51a78..64a2ad2221cc 100644 --- a/includes/specials/SpecialListDuplicatedFiles.php +++ b/includes/specials/SpecialListDuplicatedFiles.php @@ -41,7 +41,7 @@ class SpecialListDuplicatedFiles extends QueryPage { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } @@ -77,7 +77,7 @@ class SpecialListDuplicatedFiles extends QueryPage { * @param IDatabase $db * @param IResultWrapper $res */ - function preprocessResults( $db, $res ) { + public function preprocessResults( $db, $res ) { $this->executeLBFromResultWrapper( $res ); } @@ -86,7 +86,7 @@ class SpecialListDuplicatedFiles extends QueryPage { * @param object $result Result row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { // Future version might include a list of the first 5 duplicates // perhaps separated by an "↔". $image1 = Title::makeTitle( $result->namespace, $result->title ); diff --git a/includes/specials/SpecialListRedirects.php b/includes/specials/SpecialListRedirects.php index c786f13564a1..efbcd8bd893c 100644 --- a/includes/specials/SpecialListRedirects.php +++ b/includes/specials/SpecialListRedirects.php @@ -32,7 +32,7 @@ use Wikimedia\Rdbms\IResultWrapper; * @ingroup SpecialPage */ class SpecialListRedirects extends QueryPage { - function __construct( $name = 'Listredirects' ) { + public function __construct( $name = 'Listredirects' ) { parent::__construct( $name ); } @@ -40,11 +40,11 @@ class SpecialListRedirects extends QueryPage { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } - function sortDescending() { + protected function sortDescending() { return false; } @@ -67,7 +67,7 @@ class SpecialListRedirects extends QueryPage { ]; } - function getOrderFields() { + protected function getOrderFields() { return [ 'p1.page_namespace', 'p1.page_title' ]; } @@ -77,7 +77,7 @@ class SpecialListRedirects extends QueryPage { * @param IDatabase $db * @param IResultWrapper $res */ - function preprocessResults( $db, $res ) { + public function preprocessResults( $db, $res ) { if ( !$res->numRows() ) { return; } @@ -119,7 +119,7 @@ class SpecialListRedirects extends QueryPage { * @param object $result Result row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $linkRenderer = $this->getLinkRenderer(); # Make a link to the redirect itself $rd_title = Title::makeTitle( $result->namespace, $result->title ); diff --git a/includes/specials/SpecialLonelyPages.php b/includes/specials/SpecialLonelyPages.php index d1c83af38ee7..72dabd8b09a2 100644 --- a/includes/specials/SpecialLonelyPages.php +++ b/includes/specials/SpecialLonelyPages.php @@ -30,27 +30,27 @@ use MediaWiki\MediaWikiServices; * @ingroup SpecialPage */ class SpecialLonelyPages extends PageQueryPage { - function __construct( $name = 'Lonelypages' ) { + public function __construct( $name = 'Lonelypages' ) { parent::__construct( $name ); } - function getPageHeader() { + protected function getPageHeader() { return $this->msg( 'lonelypagestext' )->parseAsBlock(); } - function sortDescending() { + protected function sortDescending() { return false; } - function isExpensive() { + public function isExpensive() { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } - function getQueryInfo() { + public function getQueryInfo() { $tables = [ 'page', 'pagelinks', 'templatelinks' ]; $conds = [ 'pl_namespace IS NULL', @@ -88,7 +88,7 @@ class SpecialLonelyPages extends PageQueryPage { ]; } - function getOrderFields() { + protected function getOrderFields() { // For some crazy reason ordering by a constant // causes a filesort in MySQL 5 if ( count( MediaWikiServices::getInstance()->getNamespaceInfo()-> diff --git a/includes/specials/SpecialLongPages.php b/includes/specials/SpecialLongPages.php index 708cf2bef12f..a53d6fc6b737 100644 --- a/includes/specials/SpecialLongPages.php +++ b/includes/specials/SpecialLongPages.php @@ -25,11 +25,11 @@ * @ingroup SpecialPage */ class SpecialLongPages extends SpecialShortPages { - function __construct( $name = 'Longpages' ) { + public function __construct( $name = 'Longpages' ) { parent::__construct( $name ); } - function sortDescending() { + protected function sortDescending() { return true; } diff --git a/includes/specials/SpecialMIMESearch.php b/includes/specials/SpecialMIMESearch.php index 3cc894efc9d2..f37ee2920885 100644 --- a/includes/specials/SpecialMIMESearch.php +++ b/includes/specials/SpecialMIMESearch.php @@ -38,11 +38,11 @@ class SpecialMIMESearch extends QueryPage { return false; } - function isSyndicated() { + public function isSyndicated() { return false; } - function isCacheable() { + public function isCacheable() { return false; } @@ -105,7 +105,7 @@ class SpecialMIMESearch extends QueryPage { * is what we ideally want, so everything works out fine anyhow. * @return array */ - function getOrderFields() { + protected function getOrderFields() { return []; } @@ -113,7 +113,7 @@ class SpecialMIMESearch extends QueryPage { * Generate and output the form * @return string */ - function getPageHeader() { + protected function getPageHeader() { $formDescriptor = [ 'mime' => [ 'type' => 'combobox', @@ -184,7 +184,7 @@ class SpecialMIMESearch extends QueryPage { * @param object $result Result row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $linkRenderer = $this->getLinkRenderer(); $nt = Title::makeTitle( $result->namespace, $result->title ); diff --git a/includes/specials/SpecialMediaStatistics.php b/includes/specials/SpecialMediaStatistics.php index 4ad3b3dc08c6..af8103c68ce3 100644 --- a/includes/specials/SpecialMediaStatistics.php +++ b/includes/specials/SpecialMediaStatistics.php @@ -41,7 +41,7 @@ class SpecialMediaStatistics extends QueryPage { */ protected $totalSize = 0; - function __construct( $name = 'MediaStatistics' ) { + public function __construct( $name = 'MediaStatistics' ) { parent::__construct( $name ); // Generally speaking there is only a small number of file types, // so just show all of them. @@ -104,7 +104,7 @@ class SpecialMediaStatistics extends QueryPage { * tables will be fragmented. * @return array Fields to sort by */ - function getOrderFields() { + protected function getOrderFields() { return [ 'img_media_type', 'count(*)', 'img_major_mime', 'img_minor_mime' ]; } diff --git a/includes/specials/SpecialMostCategories.php b/includes/specials/SpecialMostCategories.php index d2748308abd2..396ebebe52e6 100644 --- a/includes/specials/SpecialMostCategories.php +++ b/includes/specials/SpecialMostCategories.php @@ -34,7 +34,7 @@ use Wikimedia\Rdbms\IResultWrapper; * @ingroup SpecialPage */ class SpecialMostCategories extends QueryPage { - function __construct( $name = 'Mostcategories' ) { + public function __construct( $name = 'Mostcategories' ) { parent::__construct( $name ); } @@ -42,7 +42,7 @@ class SpecialMostCategories extends QueryPage { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } @@ -73,7 +73,7 @@ class SpecialMostCategories extends QueryPage { * @param IDatabase $db * @param IResultWrapper $res */ - function preprocessResults( $db, $res ) { + public function preprocessResults( $db, $res ) { $this->executeLBFromResultWrapper( $res ); } @@ -82,7 +82,7 @@ class SpecialMostCategories extends QueryPage { * @param object $result Result row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $title = Title::makeTitleSafe( $result->namespace, $result->title ); if ( !$title ) { return Html::element( diff --git a/includes/specials/SpecialMostInterwikis.php b/includes/specials/SpecialMostInterwikis.php index 6f5008bcebf8..a49b98bfb98d 100644 --- a/includes/specials/SpecialMostInterwikis.php +++ b/includes/specials/SpecialMostInterwikis.php @@ -39,7 +39,7 @@ class SpecialMostInterwikis extends QueryPage { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } @@ -76,7 +76,7 @@ class SpecialMostInterwikis extends QueryPage { * @param IDatabase $db * @param IResultWrapper $res */ - function preprocessResults( $db, $res ) { + public function preprocessResults( $db, $res ) { $this->executeLBFromResultWrapper( $res ); } @@ -85,7 +85,7 @@ class SpecialMostInterwikis extends QueryPage { * @param object $result * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $title = Title::makeTitleSafe( $result->namespace, $result->title ); if ( !$title ) { return Html::element( diff --git a/includes/specials/SpecialMostLinked.php b/includes/specials/SpecialMostLinked.php index 7e0fdb2c8261..5e7ed73310ca 100644 --- a/includes/specials/SpecialMostLinked.php +++ b/includes/specials/SpecialMostLinked.php @@ -42,7 +42,7 @@ class SpecialMostLinked extends QueryPage { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } @@ -80,7 +80,7 @@ class SpecialMostLinked extends QueryPage { * @param IDatabase $db * @param IResultWrapper $res */ - function preprocessResults( $db, $res ) { + public function preprocessResults( $db, $res ) { $this->executeLBFromResultWrapper( $res ); } @@ -106,7 +106,7 @@ class SpecialMostLinked extends QueryPage { * @param object $result Result row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $title = Title::makeTitleSafe( $result->namespace, $result->title ); if ( !$title ) { return Html::element( diff --git a/includes/specials/SpecialMostLinkedCategories.php b/includes/specials/SpecialMostLinkedCategories.php index 934c3170a047..25ae09ab553c 100644 --- a/includes/specials/SpecialMostLinkedCategories.php +++ b/includes/specials/SpecialMostLinkedCategories.php @@ -33,11 +33,11 @@ use Wikimedia\Rdbms\IResultWrapper; * @ingroup SpecialPage */ class SpecialMostLinkedCategories extends QueryPage { - function __construct( $name = 'Mostlinkedcategories' ) { + public function __construct( $name = 'Mostlinkedcategories' ) { parent::__construct( $name ); } - function isSyndicated() { + public function isSyndicated() { return false; } @@ -51,7 +51,7 @@ class SpecialMostLinkedCategories extends QueryPage { ]; } - function sortDescending() { + protected function sortDescending() { return true; } @@ -61,7 +61,7 @@ class SpecialMostLinkedCategories extends QueryPage { * @param IDatabase $db * @param IResultWrapper $res */ - function preprocessResults( $db, $res ) { + public function preprocessResults( $db, $res ) { $this->executeLBFromResultWrapper( $res ); } @@ -70,7 +70,7 @@ class SpecialMostLinkedCategories extends QueryPage { * @param object $result Result row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $nt = Title::makeTitleSafe( NS_CATEGORY, $result->title ); if ( !$nt ) { return Html::element( diff --git a/includes/specials/SpecialMostLinkedTemplates.php b/includes/specials/SpecialMostLinkedTemplates.php index 0f7ac6c7b2bc..07c30acd73f7 100644 --- a/includes/specials/SpecialMostLinkedTemplates.php +++ b/includes/specials/SpecialMostLinkedTemplates.php @@ -32,7 +32,7 @@ use Wikimedia\Rdbms\IResultWrapper; * @ingroup SpecialPage */ class SpecialMostLinkedTemplates extends QueryPage { - function __construct( $name = 'Mostlinkedtemplates' ) { + public function __construct( $name = 'Mostlinkedtemplates' ) { parent::__construct( $name ); } diff --git a/includes/specials/SpecialMostRevisions.php b/includes/specials/SpecialMostRevisions.php index 60e0fe7ec406..056485f086fc 100644 --- a/includes/specials/SpecialMostRevisions.php +++ b/includes/specials/SpecialMostRevisions.php @@ -25,11 +25,11 @@ */ class SpecialMostRevisions extends SpecialFewestRevisions { - function __construct( $name = 'Mostrevisions' ) { + public function __construct( $name = 'Mostrevisions' ) { parent::__construct( $name ); } - function sortDescending() { + protected function sortDescending() { return true; } diff --git a/includes/specials/SpecialMostimages.php b/includes/specials/SpecialMostimages.php index 1339f4bcbb45..6fb0afd1a16c 100644 --- a/includes/specials/SpecialMostimages.php +++ b/includes/specials/SpecialMostimages.php @@ -30,19 +30,19 @@ * @ingroup SpecialPage */ class MostimagesPage extends ImageQueryPage { - function __construct( $name = 'Mostimages' ) { + public function __construct( $name = 'Mostimages' ) { parent::__construct( $name ); } - function isExpensive() { + public function isExpensive() { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } - function getQueryInfo() { + public function getQueryInfo() { return [ 'tables' => [ 'imagelinks' ], 'fields' => [ diff --git a/includes/specials/SpecialPagesWithProp.php b/includes/specials/SpecialPagesWithProp.php index 801c52e4ba6c..e0664f4ed5b1 100644 --- a/includes/specials/SpecialPagesWithProp.php +++ b/includes/specials/SpecialPagesWithProp.php @@ -54,11 +54,11 @@ class SpecialPagesWithProp extends QueryPage { */ private $sortByValue = false; - function __construct( $name = 'PagesWithProp' ) { + public function __construct( $name = 'PagesWithProp' ) { parent::__construct( $name ); } - function isCacheable() { + public function isCacheable() { return false; } @@ -147,7 +147,7 @@ class SpecialPagesWithProp extends QueryPage { * Disable RSS/Atom feeds * @return bool */ - function isSyndicated() { + public function isSyndicated() { return false; } @@ -179,7 +179,7 @@ class SpecialPagesWithProp extends QueryPage { return $query; } - function getOrderFields() { + protected function getOrderFields() { $sort = [ 'page_id' ]; if ( $this->sortByValue ) { array_unshift( $sort, 'pp_sortkey' ); @@ -199,7 +199,7 @@ class SpecialPagesWithProp extends QueryPage { * @param object $result Result row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $title = Title::newFromRow( $result ); $ret = $this->getLinkRenderer()->makeKnownLink( $title ); if ( $result->pp_value !== '' ) { diff --git a/includes/specials/SpecialPrefixindex.php b/includes/specials/SpecialPrefixindex.php index f7906dbb2977..3b8a58cd7eee 100644 --- a/includes/specials/SpecialPrefixindex.php +++ b/includes/specials/SpecialPrefixindex.php @@ -39,7 +39,7 @@ class SpecialPrefixindex extends SpecialAllPages { // Inherit $maxPerPage - function __construct() { + public function __construct() { parent::__construct( 'Prefixindex' ); } @@ -47,7 +47,7 @@ class SpecialPrefixindex extends SpecialAllPages { * Entry point : initialise variables and call subfunctions. * @param string $par Becomes "FOO" when called like Special:Prefixindex/FOO (default null) */ - function execute( $par ) { + public function execute( $par ) { $this->setHeaders(); $this->outputHeader(); diff --git a/includes/specials/SpecialProtectedtitles.php b/includes/specials/SpecialProtectedtitles.php index 4b0997e91977..4c6a60ad210a 100644 --- a/includes/specials/SpecialProtectedtitles.php +++ b/includes/specials/SpecialProtectedtitles.php @@ -34,7 +34,7 @@ class SpecialProtectedtitles extends SpecialPage { parent::__construct( 'Protectedtitles' ); } - function execute( $par ) { + public function execute( $par ) { $this->setHeaders(); $this->outputHeader(); $this->addHelpLink( 'Help:Protected_pages' ); @@ -67,7 +67,7 @@ class SpecialProtectedtitles extends SpecialPage { * @param object $row Database row * @return string */ - function formatRow( $row ) { + public function formatRow( $row ) { $title = Title::makeTitleSafe( $row->pt_namespace, $row->pt_title ); if ( !$title ) { return Html::rawElement( diff --git a/includes/specials/SpecialRandomredirect.php b/includes/specials/SpecialRandomredirect.php index 7c36a28a2fcd..9c0eaa1ffe37 100644 --- a/includes/specials/SpecialRandomredirect.php +++ b/includes/specials/SpecialRandomredirect.php @@ -28,7 +28,7 @@ * @ingroup SpecialPage */ class SpecialRandomredirect extends RandomPage { - function __construct() { + public function __construct() { parent::__construct( 'Randomredirect' ); $this->isRedir = true; } diff --git a/includes/specials/SpecialRecentChanges.php b/includes/specials/SpecialRecentChanges.php index 087de13c0aca..018a195039c2 100644 --- a/includes/specials/SpecialRecentChanges.php +++ b/includes/specials/SpecialRecentChanges.php @@ -566,7 +566,7 @@ class SpecialRecentChanges extends ChangesListSpecialPage { * * @param FormOptions $opts Unused */ - function setTopText( FormOptions $opts ) { + public function setTopText( FormOptions $opts ) { $message = $this->msg( 'recentchangestext' )->inContentLanguage(); if ( !$message->isDisabled() ) { $services = MediaWikiServices::getInstance(); diff --git a/includes/specials/SpecialRecentChangesLinked.php b/includes/specials/SpecialRecentChangesLinked.php index 2335675bf4c2..8770beae1a15 100644 --- a/includes/specials/SpecialRecentChangesLinked.php +++ b/includes/specials/SpecialRecentChangesLinked.php @@ -32,7 +32,7 @@ class SpecialRecentChangesLinked extends SpecialRecentChanges { /** @var bool|Title */ protected $rclTargetTitle; - function __construct() { + public function __construct() { parent::__construct( 'Recentchangeslinked' ); } @@ -237,7 +237,7 @@ class SpecialRecentChangesLinked extends SpecialRecentChanges { return $dbr->query( $sql, __METHOD__ ); } - function setTopText( FormOptions $opts ) { + public function setTopText( FormOptions $opts ) { $target = $this->getTargetTitle(); if ( $target ) { $this->getOutput()->addBacklinkSubtitle( $target ); diff --git a/includes/specials/SpecialRedirect.php b/includes/specials/SpecialRedirect.php index 4659c587899d..d3ce3e3ea00a 100644 --- a/includes/specials/SpecialRedirect.php +++ b/includes/specials/SpecialRedirect.php @@ -50,7 +50,7 @@ class SpecialRedirect extends FormSpecialPage { */ protected $mValue; - function __construct() { + public function __construct() { parent::__construct( 'Redirect' ); $this->mType = null; $this->mValue = null; diff --git a/includes/specials/SpecialShortPages.php b/includes/specials/SpecialShortPages.php index 3528ea14eed6..a5ff00d1afb2 100644 --- a/includes/specials/SpecialShortPages.php +++ b/includes/specials/SpecialShortPages.php @@ -33,11 +33,11 @@ use Wikimedia\Rdbms\IResultWrapper; */ class SpecialShortPages extends QueryPage { - function __construct( $name = 'Shortpages' ) { + public function __construct( $name = 'Shortpages' ) { parent::__construct( $name ); } - function isSyndicated() { + public function isSyndicated() { return false; } @@ -122,7 +122,7 @@ class SpecialShortPages extends QueryPage { return $res; } - function getOrderFields() { + protected function getOrderFields() { return [ 'page_len' ]; } @@ -130,11 +130,11 @@ class SpecialShortPages extends QueryPage { * @param IDatabase $db * @param IResultWrapper $res */ - function preprocessResults( $db, $res ) { + public function preprocessResults( $db, $res ) { $this->executeLBFromResultWrapper( $res ); } - function sortDescending() { + protected function sortDescending() { return false; } @@ -143,7 +143,7 @@ class SpecialShortPages extends QueryPage { * @param object $result Result row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $dm = $this->getLanguage()->getDirMark(); $title = Title::makeTitleSafe( $result->namespace, $result->title ); diff --git a/includes/specials/SpecialSpecialpages.php b/includes/specials/SpecialSpecialpages.php index ee174ac60c8a..292fed2d9ceb 100644 --- a/includes/specials/SpecialSpecialpages.php +++ b/includes/specials/SpecialSpecialpages.php @@ -30,11 +30,11 @@ use MediaWiki\MediaWikiServices; */ class SpecialSpecialpages extends UnlistedSpecialPage { - function __construct() { + public function __construct() { parent::__construct( 'Specialpages' ); } - function execute( $par ) { + public function execute( $par ) { $out = $this->getOutput(); $this->setHeaders(); $this->outputHeader(); diff --git a/includes/specials/SpecialTrackingCategories.php b/includes/specials/SpecialTrackingCategories.php index e8eb004761d0..ed1430948cf0 100644 --- a/includes/specials/SpecialTrackingCategories.php +++ b/includes/specials/SpecialTrackingCategories.php @@ -32,11 +32,11 @@ */ class SpecialTrackingCategories extends SpecialPage { - function __construct() { + public function __construct() { parent::__construct( 'TrackingCategories' ); } - function execute( $par ) { + public function execute( $par ) { $this->setHeaders(); $this->outputHeader(); $this->addHelpLink( 'Help:Categories' ); diff --git a/includes/specials/SpecialUncategorizedCategories.php b/includes/specials/SpecialUncategorizedCategories.php index 7349d95e1867..39f04639f6bd 100644 --- a/includes/specials/SpecialUncategorizedCategories.php +++ b/includes/specials/SpecialUncategorizedCategories.php @@ -34,7 +34,7 @@ class SpecialUncategorizedCategories extends SpecialUncategorizedPages { */ private $exceptionList = null; - function __construct( $name = 'Uncategorizedcategories' ) { + public function __construct( $name = 'Uncategorizedcategories' ) { parent::__construct( $name ); $this->requestedNamespace = NS_CATEGORY; } @@ -85,7 +85,7 @@ class SpecialUncategorizedCategories extends SpecialUncategorizedPages { * @param object $result The query result * @return string The category link */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $title = Title::makeTitle( NS_CATEGORY, $result->title ); $text = $title->getText(); diff --git a/includes/specials/SpecialUncategorizedImages.php b/includes/specials/SpecialUncategorizedImages.php index 67a2edb4ab1b..7d8000bf3123 100644 --- a/includes/specials/SpecialUncategorizedImages.php +++ b/includes/specials/SpecialUncategorizedImages.php @@ -29,28 +29,28 @@ * @todo FIXME: Use an instance of UncategorizedPagesPage or something */ class SpecialUncategorizedImages extends ImageQueryPage { - function __construct( $name = 'Uncategorizedimages' ) { + public function __construct( $name = 'Uncategorizedimages' ) { parent::__construct( $name ); $this->addHelpLink( 'Help:Categories' ); } - function sortDescending() { + protected function sortDescending() { return false; } - function isExpensive() { + public function isExpensive() { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } - function getOrderFields() { + protected function getOrderFields() { return [ 'title' ]; } - function getQueryInfo() { + public function getQueryInfo() { return [ 'tables' => [ 'page', 'categorylinks' ], 'fields' => [ diff --git a/includes/specials/SpecialUncategorizedPages.php b/includes/specials/SpecialUncategorizedPages.php index 2ec020afd93c..5b429e806062 100644 --- a/includes/specials/SpecialUncategorizedPages.php +++ b/includes/specials/SpecialUncategorizedPages.php @@ -33,24 +33,24 @@ class SpecialUncategorizedPages extends PageQueryPage { /** @var int|false */ protected $requestedNamespace = false; - function __construct( $name = 'Uncategorizedpages' ) { + public function __construct( $name = 'Uncategorizedpages' ) { parent::__construct( $name ); $this->addHelpLink( 'Help:Categories' ); } - function sortDescending() { + protected function sortDescending() { return false; } - function isExpensive() { + public function isExpensive() { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } - function getQueryInfo() { + public function getQueryInfo() { return [ 'tables' => [ 'page', 'categorylinks' ], 'fields' => [ @@ -73,7 +73,7 @@ class SpecialUncategorizedPages extends PageQueryPage { ]; } - function getOrderFields() { + protected function getOrderFields() { // For some crazy reason ordering by a constant // causes a filesort if ( $this->requestedNamespace === false && diff --git a/includes/specials/SpecialUndelete.php b/includes/specials/SpecialUndelete.php index d700fed27d5e..933d9cb91725 100644 --- a/includes/specials/SpecialUndelete.php +++ b/includes/specials/SpecialUndelete.php @@ -65,7 +65,7 @@ class SpecialUndelete extends SpecialPage { */ private $mSearchPrefix; - function __construct() { + public function __construct() { parent::__construct( 'Undelete', 'deletedhistory' ); } @@ -195,7 +195,7 @@ class SpecialUndelete extends SpecialPage { } } - function execute( $par ) { + public function execute( $par ) { $this->useTransactionalTimeLimit(); $user = $this->getUser(); diff --git a/includes/specials/SpecialUnusedCategories.php b/includes/specials/SpecialUnusedCategories.php index f8c9360acf7d..97f2691a9028 100644 --- a/includes/specials/SpecialUnusedCategories.php +++ b/includes/specials/SpecialUnusedCategories.php @@ -25,7 +25,7 @@ * @ingroup SpecialPage */ class SpecialUnusedCategories extends QueryPage { - function __construct( $name = 'Unusedcategories' ) { + public function __construct( $name = 'Unusedcategories' ) { parent::__construct( $name ); } @@ -33,11 +33,11 @@ class SpecialUnusedCategories extends QueryPage { return true; } - function getPageHeader() { + protected function getPageHeader() { return $this->msg( 'unusedcategoriestext' )->parseAsBlock(); } - function getOrderFields() { + protected function getOrderFields() { return [ 'title' ]; } @@ -68,7 +68,7 @@ class SpecialUnusedCategories extends QueryPage { * A should come before Z (T32907) * @return bool */ - function sortDescending() { + protected function sortDescending() { return false; } @@ -77,7 +77,7 @@ class SpecialUnusedCategories extends QueryPage { * @param object $result Result row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $title = Title::makeTitle( NS_CATEGORY, $result->title ); return $this->getLinkRenderer()->makeLink( $title, $title->getText() ); diff --git a/includes/specials/SpecialUnusedImages.php b/includes/specials/SpecialUnusedImages.php index cb215e35452e..20ecfe67aa84 100644 --- a/includes/specials/SpecialUnusedImages.php +++ b/includes/specials/SpecialUnusedImages.php @@ -27,23 +27,23 @@ * @ingroup SpecialPage */ class SpecialUnusedImages extends ImageQueryPage { - function __construct( $name = 'Unusedimages' ) { + public function __construct( $name = 'Unusedimages' ) { parent::__construct( $name ); } - function isExpensive() { + public function isExpensive() { return true; } - function sortDescending() { + protected function sortDescending() { return false; } - function isSyndicated() { + public function isSyndicated() { return false; } - function getQueryInfo() { + public function getQueryInfo() { $retval = [ 'tables' => [ 'image', 'imagelinks' ], 'fields' => [ @@ -75,7 +75,7 @@ class SpecialUnusedImages extends ImageQueryPage { return true; } - function getPageHeader() { + protected function getPageHeader() { if ( $this->getConfig()->get( 'CountCategorizedImagesAsUsed' ) ) { return $this->msg( 'unusedimagestext-categorizedimgisused' diff --git a/includes/specials/SpecialUnusedTemplates.php b/includes/specials/SpecialUnusedTemplates.php index 89468d296c23..724544407c5d 100644 --- a/includes/specials/SpecialUnusedTemplates.php +++ b/includes/specials/SpecialUnusedTemplates.php @@ -30,7 +30,7 @@ * @ingroup SpecialPage */ class SpecialUnusedTemplates extends QueryPage { - function __construct( $name = 'Unusedtemplates' ) { + public function __construct( $name = 'Unusedtemplates' ) { parent::__construct( $name ); } @@ -38,15 +38,15 @@ class SpecialUnusedTemplates extends QueryPage { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } - function sortDescending() { + protected function sortDescending() { return false; } - function getOrderFields() { + protected function getOrderFields() { return [ 'title' ]; } @@ -73,7 +73,7 @@ class SpecialUnusedTemplates extends QueryPage { * @param object $result Result row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $linkRenderer = $this->getLinkRenderer(); $title = Title::makeTitle( NS_TEMPLATE, $result->title ); $pageLink = $linkRenderer->makeKnownLink( @@ -90,7 +90,7 @@ class SpecialUnusedTemplates extends QueryPage { return $this->getLanguage()->specialList( $pageLink, $wlhLink ); } - function getPageHeader() { + protected function getPageHeader() { return $this->msg( 'unusedtemplatestext' )->parseAsBlock(); } diff --git a/includes/specials/SpecialUnwatchedPages.php b/includes/specials/SpecialUnwatchedPages.php index cc1eb342114f..cd0177786618 100644 --- a/includes/specials/SpecialUnwatchedPages.php +++ b/includes/specials/SpecialUnwatchedPages.php @@ -34,7 +34,7 @@ use Wikimedia\Rdbms\IResultWrapper; */ class SpecialUnwatchedPages extends QueryPage { - function __construct( $name = 'Unwatchedpages' ) { + public function __construct( $name = 'Unwatchedpages' ) { parent::__construct( $name, 'unwatchedpages' ); } @@ -42,7 +42,7 @@ class SpecialUnwatchedPages extends QueryPage { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } @@ -86,11 +86,11 @@ class SpecialUnwatchedPages extends QueryPage { ]; } - function sortDescending() { + protected function sortDescending() { return false; } - function getOrderFields() { + protected function getOrderFields() { return [ 'page_namespace', 'page_title' ]; } @@ -109,7 +109,7 @@ class SpecialUnwatchedPages extends QueryPage { * @param object $result Result row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $nt = Title::makeTitleSafe( $result->namespace, $result->title ); if ( !$nt ) { return Html::element( 'span', [ 'class' => 'mw-invalidtitle' ], diff --git a/includes/specials/SpecialUserLogout.php b/includes/specials/SpecialUserLogout.php index 4ee0ffcd8581..fba99a882ce9 100644 --- a/includes/specials/SpecialUserLogout.php +++ b/includes/specials/SpecialUserLogout.php @@ -27,7 +27,7 @@ * @ingroup SpecialPage */ class SpecialUserLogout extends FormSpecialPage { - function __construct() { + public function __construct() { parent::__construct( 'Userlogout' ); } diff --git a/includes/specials/SpecialWantedCategories.php b/includes/specials/SpecialWantedCategories.php index 21e42fd9826f..609a65b87251 100644 --- a/includes/specials/SpecialWantedCategories.php +++ b/includes/specials/SpecialWantedCategories.php @@ -31,11 +31,11 @@ class SpecialWantedCategories extends WantedQueryPage { private $currentCategoryCounts; - function __construct( $name = 'Wantedcategories' ) { + public function __construct( $name = 'Wantedcategories' ) { parent::__construct( $name ); } - function getQueryInfo() { + public function getQueryInfo() { return [ 'tables' => [ 'categorylinks', 'page' ], 'fields' => [ @@ -51,7 +51,7 @@ class SpecialWantedCategories extends WantedQueryPage { ]; } - function preprocessResults( $db, $res ) { + public function preprocessResults( $db, $res ) { parent::preprocessResults( $db, $res ); $this->currentCategoryCounts = []; @@ -87,7 +87,7 @@ class SpecialWantedCategories extends WantedQueryPage { * @param object $result Result row * @return string */ - function formatResult( $skin, $result ) { + public function formatResult( $skin, $result ) { $nt = Title::makeTitle( $result->namespace, $result->title ); $text = new HtmlArmor( $this->getLanguageConverter()->convertHtml( $nt->getText() ) ); diff --git a/includes/specials/SpecialWantedfiles.php b/includes/specials/SpecialWantedfiles.php index b42e5a95316a..9420697a58a3 100644 --- a/includes/specials/SpecialWantedfiles.php +++ b/includes/specials/SpecialWantedfiles.php @@ -33,11 +33,11 @@ use MediaWiki\MediaWikiServices; */ class WantedFilesPage extends WantedQueryPage { - function __construct( $name = 'Wantedfiles' ) { + public function __construct( $name = 'Wantedfiles' ) { parent::__construct( $name ); } - function getPageHeader() { + protected function getPageHeader() { # Specifically setting to use "Wanted Files" (NS_MAIN) as title, so as to get what # category would be used on main namespace pages, for those tricky wikipedia # admins who like to do {{#ifeq:{{NAMESPACE}}|foo|bar|....}}. @@ -109,7 +109,7 @@ class WantedFilesPage extends WantedQueryPage { return (bool)MediaWikiServices::getInstance()->getRepoGroup()->findFile( $title ); } - function getQueryInfo() { + public function getQueryInfo() { return [ 'tables' => [ 'imagelinks', diff --git a/includes/specials/SpecialWantedpages.php b/includes/specials/SpecialWantedpages.php index 8cea6ccb7768..27c8c8fb2d75 100644 --- a/includes/specials/SpecialWantedpages.php +++ b/includes/specials/SpecialWantedpages.php @@ -28,15 +28,15 @@ */ class WantedPagesPage extends WantedQueryPage { - function __construct( $name = 'Wantedpages' ) { + public function __construct( $name = 'Wantedpages' ) { parent::__construct( $name ); } - function isIncludable() { + public function isIncludable() { return true; } - function execute( $par ) { + public function execute( $par ) { $inc = $this->including(); if ( $inc ) { @@ -48,7 +48,7 @@ class WantedPagesPage extends WantedQueryPage { parent::execute( $par ); } - function getQueryInfo() { + public function getQueryInfo() { $dbr = wfGetDB( DB_REPLICA ); $count = $this->getConfig()->get( 'WantedPagesThreshold' ) - 1; $query = [ diff --git a/includes/specials/SpecialWatchlist.php b/includes/specials/SpecialWatchlist.php index c4b4d9f9e507..df1db98b36dc 100644 --- a/includes/specials/SpecialWatchlist.php +++ b/includes/specials/SpecialWatchlist.php @@ -58,7 +58,7 @@ class SpecialWatchlist extends ChangesListSpecialPage { * * @param string $subpage */ - function execute( $subpage ) { + public function execute( $subpage ) { // Anons don't get a watchlist $this->requireLogin( 'watchlistanontext' ); diff --git a/includes/specials/SpecialWhatLinksHere.php b/includes/specials/SpecialWhatLinksHere.php index 045d5ac85076..b2e440b511f4 100644 --- a/includes/specials/SpecialWhatLinksHere.php +++ b/includes/specials/SpecialWhatLinksHere.php @@ -44,7 +44,7 @@ class SpecialWhatLinksHere extends IncludableSpecialPage { parent::__construct( 'Whatlinkshere' ); } - function execute( $par ) { + public function execute( $par ) { $out = $this->getOutput(); $this->setHeaders(); diff --git a/includes/specials/SpecialWithoutInterwiki.php b/includes/specials/SpecialWithoutInterwiki.php index 3ab0ef97f1bd..1b7f633c8e82 100644 --- a/includes/specials/SpecialWithoutInterwiki.php +++ b/includes/specials/SpecialWithoutInterwiki.php @@ -32,17 +32,17 @@ use MediaWiki\MediaWikiServices; class SpecialWithoutInterwiki extends PageQueryPage { private $prefix = ''; - function __construct( $name = 'Withoutinterwiki' ) { + public function __construct( $name = 'Withoutinterwiki' ) { parent::__construct( $name ); } - function execute( $par ) { + public function execute( $par ) { $this->prefix = Title::capitalize( $this->getRequest()->getVal( 'prefix', $par ), NS_MAIN ); parent::execute( $par ); } - function getPageHeader() { + protected function getPageHeader() { # Do not show useless input form if special page is cached if ( $this->isCached() ) { return ''; @@ -67,23 +67,23 @@ class SpecialWithoutInterwiki extends PageQueryPage { ->displayForm( false ); } - function sortDescending() { + protected function sortDescending() { return false; } - function getOrderFields() { + protected function getOrderFields() { return [ 'page_namespace', 'page_title' ]; } - function isExpensive() { + public function isExpensive() { return true; } - function isSyndicated() { + public function isSyndicated() { return false; } - function getQueryInfo() { + public function getQueryInfo() { $query = [ 'tables' => [ 'page', 'langlinks' ], 'fields' => [ diff --git a/includes/specials/helpers/ImportReporter.php b/includes/specials/helpers/ImportReporter.php index 0dcc781b7385..5a945a95968e 100644 --- a/includes/specials/helpers/ImportReporter.php +++ b/includes/specials/helpers/ImportReporter.php @@ -40,7 +40,7 @@ class ImportReporter extends ContextSource { * @param string $interwiki * @param string|bool $reason */ - function __construct( $importer, $upload, $interwiki, $reason = false ) { + public function __construct( $importer, $upload, $interwiki, $reason = false ) { $this->mOriginalPageOutCallback = $importer->setPageOutCallback( [ $this, 'reportPage' ] ); $this->mOriginalLogCallback = diff --git a/includes/specials/pagers/ActiveUsersPager.php b/includes/specials/pagers/ActiveUsersPager.php index 46871b02a354..89d1e215b473 100644 --- a/includes/specials/pagers/ActiveUsersPager.php +++ b/includes/specials/pagers/ActiveUsersPager.php @@ -80,11 +80,11 @@ class ActiveUsersPager extends UsersPager { } } - function getIndexField() { + public function getIndexField() { return 'qcc_title'; } - function getQueryInfo( $data = null ) { + public function getQueryInfo( $data = null ) { $dbr = $this->getDatabase(); $activeUserSeconds = $this->getConfig()->get( 'ActiveUserDays' ) * 86400; @@ -221,7 +221,7 @@ class ActiveUsersPager extends UsersPager { $this->mResult->seek( 0 ); } - function formatRow( $row ) { + public function formatRow( $row ) { $userName = $row->user_name; $ulinks = Linker::userLink( $row->user_id, $userName ); diff --git a/includes/specials/pagers/AllMessagesTablePager.php b/includes/specials/pagers/AllMessagesTablePager.php index d388c27f9630..992b340273c9 100644 --- a/includes/specials/pagers/AllMessagesTablePager.php +++ b/includes/specials/pagers/AllMessagesTablePager.php @@ -296,7 +296,7 @@ class AllMessagesTablePager extends TablePager { * @param stdClass $row * @return string HTML */ - function formatRow( $row ) { + public function formatRow( $row ) { // Do all the normal stuff $s = parent::formatRow( $row ); @@ -356,7 +356,7 @@ class AllMessagesTablePager extends TablePager { return SpecialPage::getTitleFor( 'Allmessages', false ); } - function isFieldSortable( $x ) { + protected function isFieldSortable( $x ) { return false; } @@ -364,7 +364,7 @@ class AllMessagesTablePager extends TablePager { return ''; } - function getQueryInfo() { + public function getQueryInfo() { return []; } diff --git a/includes/specials/pagers/BlockListPager.php b/includes/specials/pagers/BlockListPager.php index 96a7a99ebf1e..e87840d27449 100644 --- a/includes/specials/pagers/BlockListPager.php +++ b/includes/specials/pagers/BlockListPager.php @@ -331,7 +331,7 @@ class BlockListPager extends TablePager { ); } - function getQueryInfo() { + public function getQueryInfo() { $commentQuery = CommentStore::getStore()->getJoin( 'ipb_reason' ); $actorQuery = ActorMigration::newMigration()->getJoin( 'ipb_by' ); @@ -402,7 +402,7 @@ class BlockListPager extends TablePager { return parent::getTableClass() . ' mw-blocklist'; } - function getIndexField() { + public function getIndexField() { return [ [ 'ipb_timestamp', 'ipb_id' ] ]; } @@ -410,7 +410,7 @@ class BlockListPager extends TablePager { return ''; } - function isFieldSortable( $name ) { + protected function isFieldSortable( $name ) { return false; } @@ -418,7 +418,7 @@ class BlockListPager extends TablePager { * Do a LinkBatch query to minimise database load when generating all these links * @param IResultWrapper $result */ - function preprocessResults( $result ) { + public function preprocessResults( $result ) { # Do a link batch query $lb = new LinkBatch; $lb->setCaller( __METHOD__ ); diff --git a/includes/specials/pagers/CategoryPager.php b/includes/specials/pagers/CategoryPager.php index db2ee388b5f6..03adc7f04212 100644 --- a/includes/specials/pagers/CategoryPager.php +++ b/includes/specials/pagers/CategoryPager.php @@ -41,7 +41,7 @@ class CategoryPager extends AlphabeticPager { } } - function getQueryInfo() { + public function getQueryInfo() { return [ 'tables' => [ 'category' ], 'fields' => [ 'cat_title', 'cat_pages' ], @@ -49,7 +49,7 @@ class CategoryPager extends AlphabeticPager { ]; } - function getIndexField() { + public function getIndexField() { return 'cat_title'; } @@ -75,7 +75,7 @@ class CategoryPager extends AlphabeticPager { return parent::getBody(); } - function formatRow( $result ) { + public function formatRow( $result ) { $title = new TitleValue( NS_CATEGORY, $result->cat_title ); $text = $title->getText(); $link = $this->getLinkRenderer()->makeLink( $title, $text ); diff --git a/includes/specials/pagers/ContribsPager.php b/includes/specials/pagers/ContribsPager.php index 5454b2531ea5..93d5994972d0 100644 --- a/includes/specials/pagers/ContribsPager.php +++ b/includes/specials/pagers/ContribsPager.php @@ -260,7 +260,7 @@ class ContribsPager extends RangeChronologicalPager { return 'revision'; } - function getQueryInfo() { + public function getQueryInfo() { $revQuery = MediaWikiServices::getInstance() ->getRevisionStore() ->getQueryInfo( [ 'page', 'user' ] ); @@ -588,7 +588,7 @@ class ContribsPager extends RangeChronologicalPager { * @param object $row * @return string */ - function formatRow( $row ) { + public function formatRow( $row ) { $ret = ''; $classes = []; $attribs = []; diff --git a/includes/specials/pagers/DeletedContribsPager.php b/includes/specials/pagers/DeletedContribsPager.php index 7545b1d88622..f769eee06b28 100644 --- a/includes/specials/pagers/DeletedContribsPager.php +++ b/includes/specials/pagers/DeletedContribsPager.php @@ -82,7 +82,7 @@ class DeletedContribsPager extends IndexPager { return $query; } - function getQueryInfo() { + public function getQueryInfo() { $userCond = [ // ->getJoin() below takes care of any joins needed ActorMigration::newMigration()->getWhere( @@ -160,7 +160,7 @@ class DeletedContribsPager extends IndexPager { return new FakeResultWrapper( $result ); } - function getIndexField() { + public function getIndexField() { return 'ar_timestamp'; } @@ -232,7 +232,7 @@ class DeletedContribsPager extends IndexPager { * @param stdClass $row * @return string */ - function formatRow( $row ) { + public function formatRow( $row ) { $ret = ''; $classes = []; $attribs = []; diff --git a/includes/specials/pagers/ImageListPager.php b/includes/specials/pagers/ImageListPager.php index 52b8f1915d8d..7c0366e64cd3 100644 --- a/includes/specials/pagers/ImageListPager.php +++ b/includes/specials/pagers/ImageListPager.php @@ -201,7 +201,7 @@ class ImageListPager extends TablePager { return $this->mFieldNames; } - function isFieldSortable( $field ) { + protected function isFieldSortable( $field ) { if ( $this->mIncluding ) { return false; } @@ -235,7 +235,7 @@ class ImageListPager extends TablePager { return in_array( $field, $sortable ); } - function getQueryInfo() { + public function getQueryInfo() { // Hacky Hacky Hacky - I want to get query info // for two different tables, without reimplementing // the pager class. diff --git a/includes/specials/pagers/MergeHistoryPager.php b/includes/specials/pagers/MergeHistoryPager.php index c929cf8166b8..4eebf89952e0 100644 --- a/includes/specials/pagers/MergeHistoryPager.php +++ b/includes/specials/pagers/MergeHistoryPager.php @@ -83,11 +83,11 @@ class MergeHistoryPager extends ReverseChronologicalPager { return ''; } - function formatRow( $row ) { + public function formatRow( $row ) { return $this->mForm->formatRevisionRow( $row ); } - function getQueryInfo() { + public function getQueryInfo() { $conds = $this->mConds; $conds['rev_page'] = $this->articleID; $conds[] = "rev_timestamp < " . $this->mDb->addQuotes( $this->maxTimestamp ); @@ -105,7 +105,7 @@ class MergeHistoryPager extends ReverseChronologicalPager { ]; } - function getIndexField() { + public function getIndexField() { return 'rev_timestamp'; } } diff --git a/includes/specials/pagers/NewFilesPager.php b/includes/specials/pagers/NewFilesPager.php index 1c9b9fd6956d..55e5d46722da 100644 --- a/includes/specials/pagers/NewFilesPager.php +++ b/includes/specials/pagers/NewFilesPager.php @@ -61,7 +61,7 @@ class NewFilesPager extends RangeChronologicalPager { $this->getDateRangeCond( $startTimestamp, $endTimestamp ); } - function getQueryInfo() { + public function getQueryInfo() { $opts = $this->opts; $conds = []; $actorQuery = ActorMigration::newMigration()->getJoin( 'img_user' ); @@ -147,7 +147,7 @@ class NewFilesPager extends RangeChronologicalPager { return $query; } - function getIndexField() { + public function getIndexField() { return 'img_timestamp'; } @@ -170,7 +170,7 @@ class NewFilesPager extends RangeChronologicalPager { return $this->gallery->toHTML(); } - function formatRow( $row ) { + public function formatRow( $row ) { $name = $row->img_name; $user = User::newFromId( $row->img_user ); diff --git a/includes/specials/pagers/NewPagesPager.php b/includes/specials/pagers/NewPagesPager.php index 0111f6dc8c23..4bfbcd20c229 100644 --- a/includes/specials/pagers/NewPagesPager.php +++ b/includes/specials/pagers/NewPagesPager.php @@ -46,7 +46,7 @@ class NewPagesPager extends ReverseChronologicalPager { $this->opts = $opts; } - function getQueryInfo() { + public function getQueryInfo() { $rcQuery = RecentChange::getQueryInfo(); $conds = []; @@ -158,11 +158,11 @@ class NewPagesPager extends ReverseChronologicalPager { ]; } - function getIndexField() { + public function getIndexField() { return 'rc_timestamp'; } - function formatRow( $row ) { + public function formatRow( $row ) { return $this->mForm->formatRow( $row ); } diff --git a/includes/specials/pagers/ProtectedPagesPager.php b/includes/specials/pagers/ProtectedPagesPager.php index f225259ebd44..08934fd865d9 100644 --- a/includes/specials/pagers/ProtectedPagesPager.php +++ b/includes/specials/pagers/ProtectedPagesPager.php @@ -56,7 +56,7 @@ class ProtectedPagesPager extends TablePager { $this->noredirect = (bool)$noredirect; } - function preprocessResults( $result ) { + public function preprocessResults( $result ) { # Do a link batch query $lb = new LinkBatch; $userids = []; @@ -250,7 +250,7 @@ class ProtectedPagesPager extends TablePager { return $formatted; } - function getQueryInfo() { + public function getQueryInfo() { $conds = $this->mConds; $conds[] = 'pr_expiry > ' . $this->mDb->addQuotes( $this->mDb->timestamp() ) . ' OR pr_expiry IS NULL'; @@ -321,7 +321,7 @@ class ProtectedPagesPager extends TablePager { return parent::getTableClass() . ' mw-protectedpages'; } - function getIndexField() { + public function getIndexField() { return 'pr_id'; } @@ -329,7 +329,7 @@ class ProtectedPagesPager extends TablePager { return 'pr_id'; } - function isFieldSortable( $field ) { + protected function isFieldSortable( $field ) { // no index for sorting exists return false; } diff --git a/includes/specials/pagers/ProtectedTitlesPager.php b/includes/specials/pagers/ProtectedTitlesPager.php index a00b37125c81..b22dc19a74e8 100644 --- a/includes/specials/pagers/ProtectedTitlesPager.php +++ b/includes/specials/pagers/ProtectedTitlesPager.php @@ -80,14 +80,14 @@ class ProtectedTitlesPager extends AlphabeticPager { return $this->mForm->getPageTitle(); } - function formatRow( $row ) { + public function formatRow( $row ) { return $this->mForm->formatRow( $row ); } /** * @return array */ - function getQueryInfo() { + public function getQueryInfo() { $conds = $this->mConds; $conds[] = 'pt_expiry > ' . $this->mDb->addQuotes( $this->mDb->timestamp() ) . ' OR pt_expiry IS NULL'; @@ -107,7 +107,7 @@ class ProtectedTitlesPager extends AlphabeticPager { ]; } - function getIndexField() { + public function getIndexField() { return 'pt_timestamp'; } } diff --git a/includes/specials/pagers/UsersPager.php b/includes/specials/pagers/UsersPager.php index 551430ab9962..ddb141fabd9a 100644 --- a/includes/specials/pagers/UsersPager.php +++ b/includes/specials/pagers/UsersPager.php @@ -113,14 +113,14 @@ class UsersPager extends AlphabeticPager { /** * @return string */ - function getIndexField() { + public function getIndexField() { return $this->creationSort ? 'user_id' : 'user_name'; } /** * @return array */ - function getQueryInfo() { + public function getQueryInfo() { $dbr = wfGetDB( DB_REPLICA ); $conds = []; @@ -190,7 +190,7 @@ class UsersPager extends AlphabeticPager { * @param stdClass $row * @return string */ - function formatRow( $row ) { + public function formatRow( $row ) { if ( $row->user_id == 0 ) { # T18487 return ''; } @@ -299,7 +299,7 @@ class UsersPager extends AlphabeticPager { /** * @return string */ - function getPageHeader() { + public function getPageHeader() { $self = explode( '/', $this->getTitle()->getPrefixedDBkey(), 2 )[0]; $groupOptions = [ $this->msg( 'group-all' )->text() => '' ]; |