2 files changed, 68 insertions, 1 deletions
diff --git a/tests/phpunit/integration/includes/search/SearchSuggestionSetIntegrationTest.php b/tests/phpunit/integration/includes/search/SearchSuggestionSetIntegrationTest.php
new file mode 100644
index 000000000000..cf2f732a7be4
--- /dev/null
+++ b/tests/phpunit/integration/includes/search/SearchSuggestionSetIntegrationTest.php
@@ -0,0 +1,52 @@
+<?php
+
+/**
+ * Test for filter utilities.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+class SearchSuggestionSetIntegrationTest extends MediaWikiIntegrationTestCase {
+	/** @return iterable */
+	public function provideTitles(): iterable {
+		yield 'Array of 1 Title with NS:0' => [ [ Title::makeTitle( 0, 'Title' ) ], 1 ];
+
+		yield 'Array of 2 Titles with NS:0' => [
+			[ Title::makeTitle( 0, 'Title1' ), Title::makeTitle( 0, 'Title2' ) ],
+			2
+		];
+
+		yield 'Array of another Title with NS:1' => [ [ Title::makeTitle( 1, 'Test' ) ], 1 ];
+	}
+
+	/**
+	 * NOTE: This is made an integration test because SearchSuggestion::fromText()
+	 *   calls Title::isValid() when following the execution and that tries to
+	 *   access MediaWiki services to get a Title Parser object which is not possible
+	 *   in a unit test as services are not available. That's why this ends up being
+	 *   an integration test instead.
+	 *
+	 * @covers SearchSuggestionSet::fromTitles
+	 * @dataProvider provideTitles
+	 */
+	public function testFromTitles( array $titles, $expected ): void {
+		$actual = SearchSuggestionSet::fromTitles( $titles );
+
+		$this->assertSame( $expected, $actual->getSize() );
+		$this->assertInstanceOf( SearchSuggestionSet::class, $actual );
+		$this->assertCount( $expected, $actual->getSuggestions() );
+	}
+}
diff --git a/tests/phpunit/unit/includes/search/SearchSuggestionSetTest.php b/tests/phpunit/unit/includes/search/SearchSuggestionSetTest.php
index 1d78c298e376..5cd74b234243 100644
--- a/tests/phpunit/unit/includes/search/SearchSuggestionSetTest.php
+++ b/tests/phpunit/unit/includes/search/SearchSuggestionSetTest.php
@@ -107,5 +107,20 @@ class SearchSuggestionSetTest extends \MediaWikiUnitTestCase {
 		$this->assertSame( 0, $set->getSize() );
 	}
 
-	// TODO: test for fromTitles
+	/** @return iterable */
+	public function provideNoTitles(): iterable {
+		yield 'Empty Array' => [ [] ];
+	}
+
+	/**
+	 * @covers SearchSuggestionSet::fromTitles
+	 * @dataProvider provideNoTitles
+	 */
+	public function testFromNoTitles( array $titles ): void {
+		$actual = SearchSuggestionSet::fromTitles( $titles );
+
+		$this->assertSame( 0, $actual->getSize() );
+		$this->assertSame( [], $actual->getSuggestions() );
+		$this->assertInstanceOf( SearchSuggestionSet::class, $actual );
+	}
 }