diff options
author | jenkins-bot <jenkins-bot@gerrit.wikimedia.org> | 2019-05-10 17:00:15 +0000 |
---|---|---|
committer | Gerrit Code Review <gerrit@wikimedia.org> | 2019-05-10 17:00:15 +0000 |
commit | 4435211205508fd72dfc978e1e6575b1edd36050 (patch) | |
tree | fe6e4fa81e17599ae2ce8bb519906d24eefbd956 /tests | |
parent | bec3717780aa3f605a31f7cc2b18023f3d34ab26 (diff) | |
parent | fffadf725e3f3ec0196b53f8b1542b5f761a36f9 (diff) | |
download | mediawikicore-4435211205508fd72dfc978e1e6575b1edd36050.tar.gz mediawikicore-4435211205508fd72dfc978e1e6575b1edd36050.zip |
Merge "user: Remove deprecated and unused method `getPasswordValidity()`"
Diffstat (limited to 'tests')
-rw-r--r-- | tests/phpunit/includes/user/UserTest.php | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/tests/phpunit/includes/user/UserTest.php b/tests/phpunit/includes/user/UserTest.php index aeeae11833a6..c90e98890e13 100644 --- a/tests/phpunit/includes/user/UserTest.php +++ b/tests/phpunit/includes/user/UserTest.php @@ -366,7 +366,6 @@ class UserTest extends MediaWikiTestCase { * - ensure the password is not the same as the username * - ensure the username/password combo isn't forbidden * @covers User::checkPasswordValidity() - * @covers User::getPasswordValidity() * @covers User::isValidPassword() */ public function testCheckPasswordValidity() { @@ -394,7 +393,6 @@ class UserTest extends MediaWikiTestCase { ], ], ] ); - $this->hideDeprecated( 'User::getPasswordValidity' ); $user = static::getTestUser()->getUser(); @@ -405,24 +403,20 @@ class UserTest extends MediaWikiTestCase { $this->assertFalse( $user->isValidPassword( 'a' ) ); $this->assertFalse( $user->checkPasswordValidity( 'a' )->isGood() ); $this->assertTrue( $user->checkPasswordValidity( 'a' )->isOK() ); - $this->assertEquals( 'passwordtooshort', $user->getPasswordValidity( 'a' ) ); // Maximum length $longPass = str_repeat( 'a', 41 ); $this->assertFalse( $user->isValidPassword( $longPass ) ); $this->assertFalse( $user->checkPasswordValidity( $longPass )->isGood() ); $this->assertFalse( $user->checkPasswordValidity( $longPass )->isOK() ); - $this->assertEquals( 'passwordtoolong', $user->getPasswordValidity( $longPass ) ); // Matches username $this->assertFalse( $user->checkPasswordValidity( $user->getName() )->isGood() ); $this->assertTrue( $user->checkPasswordValidity( $user->getName() )->isOK() ); - $this->assertEquals( 'password-name-match', $user->getPasswordValidity( $user->getName() ) ); // On the forbidden list $user = User::newFromName( 'Useruser' ); $this->assertFalse( $user->checkPasswordValidity( 'Passpass' )->isGood() ); - $this->assertEquals( 'password-login-forbidden', $user->getPasswordValidity( 'Passpass' ) ); } /** |