From fffadf725e3f3ec0196b53f8b1542b5f761a36f9 Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Thu, 9 May 2019 23:31:17 +0100 Subject: user: Remove deprecated and unused method `getPasswordValidity()` This method was deprecated in 1.33 and no longer used. See usage; Usage ===== https://codesearch.wmflabs.org/search/?q=%5CbgetPasswordValidity%5Cb&i=nope&files=&repos= Bug: T220656 Change-Id: I28829f33d40b5568bedb9678fc43beb146b72e56 --- tests/phpunit/includes/user/UserTest.php | 6 ------ 1 file changed, 6 deletions(-) (limited to 'tests') diff --git a/tests/phpunit/includes/user/UserTest.php b/tests/phpunit/includes/user/UserTest.php index aeeae11833a6..c90e98890e13 100644 --- a/tests/phpunit/includes/user/UserTest.php +++ b/tests/phpunit/includes/user/UserTest.php @@ -366,7 +366,6 @@ class UserTest extends MediaWikiTestCase { * - ensure the password is not the same as the username * - ensure the username/password combo isn't forbidden * @covers User::checkPasswordValidity() - * @covers User::getPasswordValidity() * @covers User::isValidPassword() */ public function testCheckPasswordValidity() { @@ -394,7 +393,6 @@ class UserTest extends MediaWikiTestCase { ], ], ] ); - $this->hideDeprecated( 'User::getPasswordValidity' ); $user = static::getTestUser()->getUser(); @@ -405,24 +403,20 @@ class UserTest extends MediaWikiTestCase { $this->assertFalse( $user->isValidPassword( 'a' ) ); $this->assertFalse( $user->checkPasswordValidity( 'a' )->isGood() ); $this->assertTrue( $user->checkPasswordValidity( 'a' )->isOK() ); - $this->assertEquals( 'passwordtooshort', $user->getPasswordValidity( 'a' ) ); // Maximum length $longPass = str_repeat( 'a', 41 ); $this->assertFalse( $user->isValidPassword( $longPass ) ); $this->assertFalse( $user->checkPasswordValidity( $longPass )->isGood() ); $this->assertFalse( $user->checkPasswordValidity( $longPass )->isOK() ); - $this->assertEquals( 'passwordtoolong', $user->getPasswordValidity( $longPass ) ); // Matches username $this->assertFalse( $user->checkPasswordValidity( $user->getName() )->isGood() ); $this->assertTrue( $user->checkPasswordValidity( $user->getName() )->isOK() ); - $this->assertEquals( 'password-name-match', $user->getPasswordValidity( $user->getName() ) ); // On the forbidden list $user = User::newFromName( 'Useruser' ); $this->assertFalse( $user->checkPasswordValidity( 'Passpass' )->isGood() ); - $this->assertEquals( 'password-login-forbidden', $user->getPasswordValidity( 'Passpass' ) ); } /** -- cgit v1.2.3