UserRateLimitConstraint: move detection of content model change to constraint

A step towards a more common interface between the different
constraints, detect whether the content model changes within the
UserRateLimitConstraint rather than relying on EditPage to inject
the answer

Bug: T157658
Change-Id: Ifa35cbabe74df458784a10b3d2815a1e8e7dcdf8

1 files changed, 12 insertions, 4 deletions

diff --git a/tests/phpunit/unit/includes/editpage/Constraint/UserRateLimitConstraintTest.php b/tests/phpunit/unit/includes/editpage/Constraint/UserRateLimitConstraintTest.php
index 8106289cad4d..5c92ecfe9f29 100644
--- a/tests/phpunit/unit/includes/editpage/Constraint/UserRateLimitConstraintTest.php
+++ b/tests/phpunit/unit/includes/editpage/Constraint/UserRateLimitConstraintTest.php
@@ -62,8 +62,12 @@ class UserRateLimitConstraintTest extends MediaWikiUnitTestCase {
 				)
 			);
 
-		// true = also check for rate limit of editing content model
-		$constraint = new UserRateLimitConstraint( $user, true );
+		$title = $this->createMock( Title::class );
+		$title->expects( $this->once() )
+			->method( 'getContentModel' )
+			->willReturn( 'OldContentModel' );
+
+		$constraint = new UserRateLimitConstraint( $user, $title, 'NewContentModel' );
 		$this->assertConstraintPassed( $constraint );
 	}
 
@@ -98,8 +102,12 @@ class UserRateLimitConstraintTest extends MediaWikiUnitTestCase {
 				)
 			);
 
-		// true = also check for rate limit of editing content model
-		$constraint = new UserRateLimitConstraint( $user, true );
+		$title = $this->createMock( Title::class );
+		$title->expects( $this->once() )
+			->method( 'getContentModel' )
+			->willReturn( 'OldContentModel' );
+
+		$constraint = new UserRateLimitConstraint( $user, $title, 'NewContentModel' );
 		$this->assertConstraintFailed( $constraint, IEditConstraint::AS_RATE_LIMITED );
 	}