diff options
| author | Bartosz Dziewoński <dziewonski@fastmail.fm> | 2025-01-22 00:16:15 +0100 |
|---|---|---|
| committer | Bartosz Dziewoński <dziewonski@fastmail.fm> | 2025-02-21 01:32:21 +0100 |
| commit | a603da0381f028b30d8f4e3cf574d2c3a9e99681 (patch) | |
| tree | 74c883af2ed13449fc41856265c9ddcc061d852c /tests/phpunit/unit/includes/editpage | |
| parent | 53483008d28296035c123944b1b76b528c217af0 (diff) | |
| download | mediawikicore-a603da0381f028b30d8f4e3cf574d2c3a9e99681.tar.gz mediawikicore-a603da0381f028b30d8f4e3cf574d2c3a9e99681.zip | |
editpage: Make PageSizeConstraint provide its own error message
Instead of special-casing it in EditPage and in ApiEditPage,
PageSizeConstraint sets the error message itself.
Add some notes about T384399. I hope this change can serve as an
example for further work on that task.
Other changes:
* Do not show the error on editor load, only on edit form submission.
The error on load was added in 2006 when the maximum page size was
first limited (aa2bde93 / SVN r13070), and should not be needed any
more now that there shouldn't be any pages exceeding the limit in
the database any more. In case there are, the user will still get
the message when they try to save an edit.
* Streamline the message (there's no need for emphasis in the message,
since it's shown in a very prominent error box these days).
* Use the same message in API errors. Preserve the API error code for
compatibility.
* Alphabetically sort some arrays and switch cases.
Bug: T384399
Change-Id: I0892d1189e29013b9ff4325c8017bab524b84b7e
Diffstat (limited to 'tests/phpunit/unit/includes/editpage')
0 files changed, 0 insertions, 0 deletions