Update tests for PHPUnit 9.6 (part 1)

- Avoid defining abstract test classes (ending in "Test")
- Avoid withConsecutive()
- Avoid getMockClass()

Bug: T342110
Change-Id: I131e0d85bd14e75aaebd6f212b2e64a45d4c73a2

1 files changed, 11 insertions, 6 deletions

diff --git a/tests/phpunit/unit/includes/editpage/Constraint/UserRateLimitConstraintTest.php b/tests/phpunit/unit/includes/editpage/Constraint/UserRateLimitConstraintTest.php
index c562bb877a3d..b832aa7ee5e5 100644
--- a/tests/phpunit/unit/includes/editpage/Constraint/UserRateLimitConstraintTest.php
+++ b/tests/phpunit/unit/includes/editpage/Constraint/UserRateLimitConstraintTest.php
@@ -42,14 +42,19 @@ class UserRateLimitConstraintTest extends MediaWikiUnitTestCase {
 	 */
 	private function getRateLimiter( $fail ) {
 		$mock = $this->createNoOpMock( RateLimiter::class, [ 'limit' ] );
+		$expectedArgs = [
+			[ 'edit', 1, false ],
+			[ 'linkpurge', 0, false ],
+			[ 'editcontentmodel', 1, $fail ]
+		];
 		$mock->expects( $this->exactly( 3 ) )
 			->method( 'limit' )
-			->withConsecutive(
-				[ $this->anything(), 'edit', 1 ],
-				[ $this->anything(), 'linkpurge', 0 ],
-				[ $this->anything(), 'editcontentmodel', 1 ]
-			)
-			->willReturnOnConsecutiveCalls( false, false, $fail );
+			->willReturnCallback( function ( $_, $action, $incrBy ) use ( &$expectedArgs ) {
+				$curExpectedArgs = array_shift( $expectedArgs );
+				$this->assertSame( $curExpectedArgs[0], $action );
+				$this->assertSame( $curExpectedArgs[1], $incrBy );
+				return $curExpectedArgs[2];
+			} );
 		return $mock;
 	}