diff options
| author | Tim Starling <tstarling@wikimedia.org> | 2023-03-23 22:36:19 +1100 |
|---|---|---|
| committer | Krinkle <krinkle@fastmail.com> | 2023-03-24 02:53:57 +0000 |
| commit | 5e30a927bc2d4027a660a3f7f34315a93bb06215 (patch) | |
| tree | 5927c6b0a51ed6a5f44062c4b0a183c149170061 /tests/phpunit/unit/includes/editpage | |
| parent | 5ee6384bdf1f62e49ad6c2df600755be6bf1e815 (diff) | |
| download | mediawikicore-5e30a927bc2d4027a660a3f7f34315a93bb06215.tar.gz mediawikicore-5e30a927bc2d4027a660a3f7f34315a93bb06215.zip | |
tests: Make some PHPUnit data providers static
Just methods where adding "static" to the declaration was enough, I
didn't do anything with providers that used $this.
Initially by search and replace. There were many mistakes which I
found mostly by running the PHPStorm inspection which searches for
$this usage in a static method. Later I used the PHPStorm "make static"
action which avoids the more obvious mistakes.
Bug: T332865
Change-Id: I47ed6692945607dfa5c139d42edbd934fa4f3a36
Diffstat (limited to 'tests/phpunit/unit/includes/editpage')
3 files changed, 4 insertions, 4 deletions
diff --git a/tests/phpunit/unit/includes/editpage/Constraint/DefaultTextConstraintTest.php b/tests/phpunit/unit/includes/editpage/Constraint/DefaultTextConstraintTest.php index 5c21a58271f8..3a1b61b6a8c0 100644 --- a/tests/phpunit/unit/includes/editpage/Constraint/DefaultTextConstraintTest.php +++ b/tests/phpunit/unit/includes/editpage/Constraint/DefaultTextConstraintTest.php @@ -62,7 +62,7 @@ class DefaultTextConstraintTest extends MediaWikiUnitTestCase { $this->assertConstraintFailed( $constraint, IEditConstraint::AS_BLANK_ARTICLE ); } - public function provideTestFailure() { + public static function provideTestFailure() { yield 'Matching message text' => [ 'MessageText', 'MessageText' ]; yield 'Blank page and no default' => [ false, '' ]; } diff --git a/tests/phpunit/unit/includes/editpage/Constraint/PageSizeConstraintTest.php b/tests/phpunit/unit/includes/editpage/Constraint/PageSizeConstraintTest.php index 8a5f00f1665d..ac78b8cd5231 100644 --- a/tests/phpunit/unit/includes/editpage/Constraint/PageSizeConstraintTest.php +++ b/tests/phpunit/unit/includes/editpage/Constraint/PageSizeConstraintTest.php @@ -57,7 +57,7 @@ class PageSizeConstraintTest extends MediaWikiUnitTestCase { $this->assertConstraintFailed( $constraint, $errorCode ); } - public function provideCodes() { + public static function provideCodes() { return [ 'Before merge - CONTENT_TOO_BIG' => [ PageSizeConstraint::BEFORE_MERGE, diff --git a/tests/phpunit/unit/includes/editpage/TextboxBuilderTest.php b/tests/phpunit/unit/includes/editpage/TextboxBuilderTest.php index 56515d1859cf..9ce4419ebd49 100644 --- a/tests/phpunit/unit/includes/editpage/TextboxBuilderTest.php +++ b/tests/phpunit/unit/includes/editpage/TextboxBuilderTest.php @@ -30,7 +30,7 @@ use MediaWikiUnitTestCase; */ class TextboxBuilderTest extends MediaWikiUnitTestCase { - public function provideAddNewLineAtEnd() { + public static function provideAddNewLineAtEnd() { return [ [ '', '' ], [ 'foo', "foo\n" ], @@ -45,7 +45,7 @@ class TextboxBuilderTest extends MediaWikiUnitTestCase { $this->assertSame( $expected, $builder->addNewLineAtEnd( $input ) ); } - public function provideMergeClassesIntoAttributes() { + public static function provideMergeClassesIntoAttributes() { return [ [ [], |