Remove unnecessary ->equalTo() from tests

This is the default anyway when using ->with(). The test code
becomes so much more readable without this, I would like to
argue. Let it just say "with these values".

Because of the way I split my changes into multiple patches
there are a few other changes in this patch I could not split,
e.g. removing unnecessary ->any(). This is the default anyway
and doesn't make the test more specific.

Change-Id: I34990799fa9258ba8dc64c7e78ec43f7903b7681

1 files changed, 4 insertions, 4 deletions

diff --git a/tests/phpunit/unit/includes/editpage/Constraint/SpamRegexConstraintTest.php b/tests/phpunit/unit/includes/editpage/Constraint/SpamRegexConstraintTest.php
index 8fabbb94703c..ce39e9869490 100644
--- a/tests/phpunit/unit/includes/editpage/Constraint/SpamRegexConstraintTest.php
+++ b/tests/phpunit/unit/includes/editpage/Constraint/SpamRegexConstraintTest.php
@@ -42,13 +42,13 @@ class SpamRegexConstraintTest extends MediaWikiUnitTestCase {
 		$spamChecker = $this->createMock( SpamChecker::class );
 		$spamChecker->expects( $this->once() )
 			->method( 'checkSummary' )
-			->with( $this->equalTo( $summary ) )
+			->with( $summary )
 			->willReturn( false );
 		$spamChecker->expects( $this->exactly( 2 ) )
 			->method( 'checkContent' )
 			->withConsecutive(
-				[ $this->equalTo( $sectionHeading ) ],
-				[ $this->equalTo( $text ) ]
+				[ $sectionHeading ],
+				[ $text ]
 			)
 			->willReturn( false );
 
@@ -80,7 +80,7 @@ class SpamRegexConstraintTest extends MediaWikiUnitTestCase {
 		$spamChecker = $this->createMock( SpamChecker::class );
 		$spamChecker->expects( $this->once() )
 			->method( 'checkSummary' )
-			->with( $this->equalTo( $summary ) )
+			->with( $summary )
 			->willReturn( $matchingText );
 
 		$prefixedDBKey = 'PrefixedDBKeyGoesHere';