Update RestStructureTest to include HTTP Method

Change-Id: If05ba2884ba8e256c7fee45164eee1fc2d014589

1 files changed, 26 insertions, 3 deletions

diff --git a/tests/phpunit/structure/RestStructureTest.php b/tests/phpunit/structure/RestStructureTest.php
index b60de3e5558a..0201317ed777 100644
--- a/tests/phpunit/structure/RestStructureTest.php
+++ b/tests/phpunit/structure/RestStructureTest.php
@@ -80,10 +80,12 @@ class RestStructureTest extends MediaWikiTestCase {
 
 	public static function providePathParameters() : Iterator {
 		$router = TestingAccessWrapper::newFromObject( self::getRouter() );
-		$request = new RequestData();
 
 		foreach ( $router->getAllRoutes() as $spec ) {
-			yield "Handler {$spec['path']}" => [ $spec ];
+			$method = $spec['method'] ?? 'GET';
+			$method = implode( ",", (array)$method );
+
+			yield "Handler {$method} {$spec['path']}" => [ $spec ];
 		}
 	}
 
@@ -151,7 +153,28 @@ class RestStructureTest extends MediaWikiTestCase {
 			$handler = $router->createHandler( $request, $spec );
 			$params = $handler->getParamSettings();
 			foreach ( $params as $param => $settings ) {
-				yield "Handler {$spec['path']}, parameter $param" => [ $spec, $param, $settings ];
+				$method = $spec['method'] ?? 'GET';
+				$method = implode( ",", (array)$method );
+
+				yield "Handler {$method} {$spec['path']}, parameter $param" => [ $spec, $param, $settings ];
+			}
+		}
+	}
+
+	public function testRoutePathAndMethodForDuplicates() {
+		$router = TestingAccessWrapper::newFromObject( self::getRouter() );
+		$routes = [];
+
+		foreach ( $router->getAllRoutes() as $spec ) {
+			$method = $spec['method'] ?? 'GET';
+			$method = (array)$method;
+
+			foreach ( $method as $m ) {
+				$key = "{$m} {$spec['path']}";
+
+				$this->assertFalse( array_key_exists( $key, $routes ), "{$key} already exists in routes" );
+
+				$routes[$key] = true;
 			}
 		}
 	}