phpunit: Don't redefine methods in traits

The signatures of these methods will change in PHPUnit 9, and in
general, having these methods means additional code to maintain. Since
this is test code, any attempt to use these traits from a class which
doesn't have the required methods will fail hard, and as such, there's
no reason to have these methods at all.

Also, MockServiceDependenciesTrait was redeclaring fail() as a
non-static method, but it is actually static in the parent class, which
makes tests fail on PHP 8.

Bug: T243600
Change-Id: I78bf1bdd2eb2e09aed27d1b6bff2302e28600703

1 files changed, 0 insertions, 19 deletions

diff --git a/tests/phpunit/mocks/MockTitleTrait.php b/tests/phpunit/mocks/MockTitleTrait.php
index 1012c95e0853..233933b2905a 100644
--- a/tests/phpunit/mocks/MockTitleTrait.php
+++ b/tests/phpunit/mocks/MockTitleTrait.php
@@ -101,23 +101,4 @@ trait MockTitleTrait {
 
 		return $titleCodec;
 	}
-
-	/**
-	 * Expected to be provided by the class, probably inherited from TestCase.
-	 *
-	 * @param string $originalClassName
-	 *
-	 * @return MockObject
-	 */
-	abstract protected function createMock( $originalClassName ): MockObject;
-
-	/**
-	 * Expected to be provided by the class, probably MediaWikiTestCaseTrait.
-	 *
-	 * @param string $type
-	 * @param string[] $allow methods to allow
-	 *
-	 * @return MockObject
-	 */
-	abstract protected function createNoOpMock( $type, $allow = [] );
 }