Add ActorStore::deleteActor

This is an extremely dangerous method, but it's needed
for the temporary users magic in translate extension.
At least going via ActorStore we can keep our in-process
caches consistent and get rid of some static methods
and caching in user object.

Change-Id: I8157f7ccee7d72aee405e9b6109dfc1838e1f380

1 files changed, 24 insertions, 0 deletions

diff --git a/tests/phpunit/integration/includes/user/ActorStoreTest.php b/tests/phpunit/integration/includes/user/ActorStoreTest.php
index c0524353b366..e6a2c987cc62 100644
--- a/tests/phpunit/integration/includes/user/ActorStoreTest.php
+++ b/tests/phpunit/integration/includes/user/ActorStoreTest.php
@@ -817,6 +817,30 @@ class ActorStoreTest extends ActorStoreTestBase {
 	}
 
 	/**
+	 * @covers ::deleteActor
+	 */
+	public function testDelete() {
+		$store = $this->getStore();
+		$actor = new UserIdentityValue( 9999, 'DeleteTest' );
+		$actorId = $store->acquireActorId( $actor, $this->db );
+		$this->assertTrue( $store->deleteActor( $actor, $this->db ) );
+
+		$this->assertNull( $store->findActorId( $actor, $this->db ) );
+		$this->assertNull( $store->getUserIdentityByUserId( $actor->getId() ) );
+		$this->assertNull( $store->getUserIdentityByName( $actor->getName() ) );
+		$this->assertNull( $store->getActorById( $actorId, $this->db ) );
+	}
+
+	/**
+	 * @covers ::deleteActor
+	 */
+	public function testDeleteDoesNotExist() {
+		$this->assertFalse(
+			$this->getStore()->deleteActor( new UserIdentityValue( 9998, 'DoesNotExist' ), $this->db )
+		);
+	}
+
+	/**
 	 * @covers ::getUnknownActor
 	 */
 	public function testGetUnknownActor() {