diff options
| author | Aaron Schulz <aschulz@wikimedia.org> | 2023-05-26 19:09:31 -0700 |
|---|---|---|
| committer | Aaron Schulz <aschulz@wikimedia.org> | 2023-05-27 02:19:55 +0000 |
| commit | ac1819cc32dabcff8bf87cb7fd076556b0c03dbc (patch) | |
| tree | 7e2eb512d8cce559a96eda5367fd819e63e50929 /tests/phpunit/integration/includes/db/DatabaseSqliteTest.php | |
| parent | 498c00ab2556ad5ab561332d219bc57d52c1758d (diff) | |
| download | mediawikicore-ac1819cc32dabcff8bf87cb7fd076556b0c03dbc.tar.gz mediawikicore-ac1819cc32dabcff8bf87cb7fd076556b0c03dbc.zip | |
Remove uses Database::update()/Database::insert() return values
Change-Id: I527ea0900cc76faac9506b2a43a2b1522b35dfbd
Diffstat (limited to 'tests/phpunit/integration/includes/db/DatabaseSqliteTest.php')
| -rw-r--r-- | tests/phpunit/integration/includes/db/DatabaseSqliteTest.php | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/tests/phpunit/integration/includes/db/DatabaseSqliteTest.php b/tests/phpunit/integration/includes/db/DatabaseSqliteTest.php index 53649a850671..5d21063a6290 100644 --- a/tests/phpunit/integration/includes/db/DatabaseSqliteTest.php +++ b/tests/phpunit/integration/includes/db/DatabaseSqliteTest.php @@ -261,9 +261,7 @@ class DatabaseSqliteTest extends \MediaWikiIntegrationTestCase { $databaseCreation = $db->query( 'CREATE TABLE a ( a_1 )', __METHOD__ ); $this->assertInstanceOf( ResultWrapper::class, $databaseCreation, "Database creation" ); - $insertion = $db->insert( 'a', [ 'a_1' => 10 ], __METHOD__ ); - $this->assertTrue( $insertion, "Insertion worked" ); - + $db->insert( 'a', [ 'a_1' => 10 ], __METHOD__ ); $this->assertIsInt( $db->insertId(), "Actual typecheck" ); $this->assertTrue( $db->close(), "closing database" ); } @@ -275,7 +273,7 @@ class DatabaseSqliteTest extends \MediaWikiIntegrationTestCase { $db = DatabaseSqlite::newStandaloneInstance( ':memory:' ); $db->query( 'CREATE TABLE testInsertAffectedRows ( foo )', __METHOD__ ); - $insertion = $db->insert( + $db->insert( 'testInsertAffectedRows', [ [ 'foo' => 10 ], @@ -284,7 +282,6 @@ class DatabaseSqliteTest extends \MediaWikiIntegrationTestCase { ], __METHOD__ ); - $this->assertTrue( $insertion, "Insertion worked" ); $this->assertSame( 3, $db->affectedRows() ); $this->assertTrue( $db->close(), "closing database" ); |