diff options
| author | Thiemo Kreuz <thiemo.kreuz@wikimedia.de> | 2020-05-29 10:37:05 +0200 |
|---|---|---|
| committer | Thiemo Kreuz (WMDE) <thiemo.kreuz@wikimedia.de> | 2020-05-29 09:37:03 +0000 |
| commit | e111220a39d86f2c56566e8cc6a84429d928638c (patch) | |
| tree | f8c2fde8ff67c9b420fe80f2210c5dde9d5ffb1f /tests/phpunit/includes/upload/UploadBaseTest.php | |
| parent | bbce47b29de1587eb2dba2d2cdd4ebd5df1ed52e (diff) | |
| download | mediawikicore-e111220a39d86f2c56566e8cc6a84429d928638c.tar.gz mediawikicore-e111220a39d86f2c56566e8cc6a84429d928638c.zip | |
upload: Modernize callback code to make use of PHP7 syntax
* Update the two "processing_instruction_handler" and
"external_dtd_handler" callbacks to use a syntax for the callback
that doesn't stuff the class name in a string, but actually
references the class.
* We don't need call_user_func() in modern PHP7 any more.
* Add and update a few type hints in UploadBase to make the code
easier explorable.
Change-Id: I0ab3cfbe4f0bf15b1da4ab10fd9ffc1986d968d0
Diffstat (limited to 'tests/phpunit/includes/upload/UploadBaseTest.php')
| -rw-r--r-- | tests/phpunit/includes/upload/UploadBaseTest.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/phpunit/includes/upload/UploadBaseTest.php b/tests/phpunit/includes/upload/UploadBaseTest.php index bcc6452c4aeb..0bfdd41ac9a7 100644 --- a/tests/phpunit/includes/upload/UploadBaseTest.php +++ b/tests/phpunit/includes/upload/UploadBaseTest.php @@ -647,8 +647,8 @@ class UploadTestHandler extends UploadBase { [ $this, 'checkSvgScriptCallback' ], false, [ - 'processing_instruction_handler' => 'UploadBase::checkSvgPICallback', - 'external_dtd_handler' => 'UploadBase::checkSvgExternalDTD' + 'processing_instruction_handler' => [ UploadBase::class, 'checkSvgPICallback' ], + 'external_dtd_handler' => [ UploadBase::class, 'checkSvgExternalDTD' ], ] ); return [ $check->wellFormed, $check->filterMatch ]; |