aboutsummaryrefslogtreecommitdiffstats
path: root/tests/phpunit/includes/session/PHPSessionHandlerTest.php
diff options
context:
space:
mode:
authorGergő Tisza <tgr.huwiki@gmail.com>2025-01-06 22:23:33 +0100
committerGergő Tisza <tgr.huwiki@gmail.com>2025-01-06 22:23:33 +0100
commit3b948a3da4be2a20573db01d611d601f2f90f2e5 (patch)
tree97c535c0fd57517e70e4fb3cc856976337b70190 /tests/phpunit/includes/session/PHPSessionHandlerTest.php
parentaa4e00d412199a6e7abf3c8a3bfc66fed3e5e63a (diff)
downloadmediawikicore-3b948a3da4be2a20573db01d611d601f2f90f2e5.tar.gz
mediawikicore-3b948a3da4be2a20573db01d611d601f2f90f2e5.zip
session: Do not set session.use_trans_sid
session.use_trans_sid is a PHP antifeature that tells PHP to add session IDs to all local URLs by modifying the HTML it's told to output. We have set it to false just in case, but now that's triggering deprecation warnings. Bug: T380755 Change-Id: Iace0dcdb23eedb432cc1c032bbb3ce31d34071be
Diffstat (limited to 'tests/phpunit/includes/session/PHPSessionHandlerTest.php')
-rw-r--r--tests/phpunit/includes/session/PHPSessionHandlerTest.php2
1 files changed, 0 insertions, 2 deletions
diff --git a/tests/phpunit/includes/session/PHPSessionHandlerTest.php b/tests/phpunit/includes/session/PHPSessionHandlerTest.php
index d2b595adf1c2..e215697edf01 100644
--- a/tests/phpunit/includes/session/PHPSessionHandlerTest.php
+++ b/tests/phpunit/includes/session/PHPSessionHandlerTest.php
@@ -74,7 +74,6 @@ class PHPSessionHandlerTest extends MediaWikiIntegrationTestCase {
session_write_close();
ini_set( 'session.use_cookies', 1 );
- ini_set( 'session.use_trans_sid', 1 );
$store = new TestBagOStuff();
// Tolerate debug message, anything else is unexpected
@@ -91,7 +90,6 @@ class PHPSessionHandlerTest extends MediaWikiIntegrationTestCase {
$this->assertTrue( PHPSessionHandler::isInstalled() );
$this->assertFalse( wfIniGetBool( 'session.use_cookies' ) );
- $this->assertFalse( wfIniGetBool( 'session.use_trans_sid' ) );
$this->assertNotNull( $staticAccess->instance );
$priv = TestingAccessWrapper::newFromObject( $staticAccess->instance );