Improve test coverage in includes/password

From 21% to 82%.

* Added missing @covers, broadened @covers where appropriate.
* Added tests for some code that lacked them.
* Added a parameter to control the use of hash_pbkdf2() so that the pure
  PHP fallback could be tested. In the non-fallback test, force the use
  of the extension, and mark it skipped if it is not installed.

Bug: T167003
Change-Id: I987e1a89ec343907f4ead7f6192b2d4deb58ac16

1 files changed, 1 insertions, 8 deletions

diff --git a/tests/phpunit/includes/password/UserPasswordPolicyTest.php b/tests/phpunit/includes/password/UserPasswordPolicyTest.php
index 8a69b5ce1eba..3bd82b4ac8d7 100644
--- a/tests/phpunit/includes/password/UserPasswordPolicyTest.php
+++ b/tests/phpunit/includes/password/UserPasswordPolicyTest.php
@@ -22,6 +22,7 @@
 
 /**
  * @group Database
+ * @covers UserPasswordPolicy
  */
 class UserPasswordPolicyTest extends MediaWikiTestCase {
 
@@ -56,9 +57,6 @@ class UserPasswordPolicyTest extends MediaWikiTestCase {
 		return new UserPasswordPolicy( $this->policies, $this->checks );
 	}
 
-	/**
-	 * @covers UserPasswordPolicy::getPoliciesForUser
-	 */
 	public function testGetPoliciesForUser() {
 
 		$upp = $this->getUserPasswordPolicy();
@@ -79,9 +77,6 @@ class UserPasswordPolicyTest extends MediaWikiTestCase {
 		);
 	}
 
-	/**
-	 * @covers UserPasswordPolicy::getPoliciesForGroups
-	 */
 	public function testGetPoliciesForGroups() {
 		$effective = UserPasswordPolicy::getPoliciesForGroups(
 			$this->policies,
@@ -103,7 +98,6 @@ class UserPasswordPolicyTest extends MediaWikiTestCase {
 
 	/**
 	 * @dataProvider provideCheckUserPassword
-	 * @covers UserPasswordPolicy::checkUserPassword
 	 */
 	public function testCheckUserPassword( $username, $groups, $password, $valid, $ok, $msg ) {
 
@@ -183,7 +177,6 @@ class UserPasswordPolicyTest extends MediaWikiTestCase {
 
 	/**
 	 * @dataProvider provideMaxOfPolicies
-	 * @covers UserPasswordPolicy::maxOfPolicies
 	 */
 	public function testMaxOfPolicies( $p1, $p2, $max, $msg ) {
 		$this->assertArrayEquals(