diff options
| author | thiemowmde <thiemo.kreuz@wikimedia.de> | 2024-07-09 17:36:08 +0200 |
|---|---|---|
| committer | Thiemo Kreuz (WMDE) <thiemo.kreuz@wikimedia.de> | 2024-07-10 10:11:22 +0000 |
| commit | 4bd95cd96bd5c13424098dec38891596d68ff264 (patch) | |
| tree | 356c0e303b3207ca8ba28c5abde9db8d4f3aeda1 /tests/phpunit/includes/page/ParserOutputAccessTest.php | |
| parent | 17079782a776849ec51d5c3d3712edc217cce65b (diff) | |
| download | mediawikicore-4bd95cd96bd5c13424098dec38891596d68ff264.tar.gz mediawikicore-4bd95cd96bd5c13424098dec38891596d68ff264.zip | |
Use MainConfigNames constants in tests where possible
I believe this makes the code less brittle, and also makes it a bit
more obvious what these strings are meant to represent.
Change-Id: Ia39b5c80af4b495931d0a68fd091b783645dd709
Diffstat (limited to 'tests/phpunit/includes/page/ParserOutputAccessTest.php')
| -rw-r--r-- | tests/phpunit/includes/page/ParserOutputAccessTest.php | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/tests/phpunit/includes/page/ParserOutputAccessTest.php b/tests/phpunit/includes/page/ParserOutputAccessTest.php index d58dbbcb1474..325bddaa42bc 100644 --- a/tests/phpunit/includes/page/ParserOutputAccessTest.php +++ b/tests/phpunit/includes/page/ParserOutputAccessTest.php @@ -1,4 +1,5 @@ <?php + use MediaWiki\Json\JsonCodec; use MediaWiki\Logger\LoggerFactory; use MediaWiki\Logger\Spi as LoggerSpi; @@ -841,14 +842,12 @@ class ParserOutputAccessTest extends MediaWikiIntegrationTestCase { * @param bool $fastStale */ private function setPoolCounterFactory( $status, $fastStale = false ) { - $this->overrideConfigValues( [ - MainConfigNames::PoolCounterConf => [ - 'ArticleView' => [ - 'class' => MockPoolCounterFailing::class, - 'fastStale' => $fastStale, - 'mockAcquire' => $status, - 'mockRelease' => Status::newGood( PoolCounter::RELEASED ), - ], + $this->overrideConfigValue( MainConfigNames::PoolCounterConf, [ + 'ArticleView' => [ + 'class' => MockPoolCounterFailing::class, + 'fastStale' => $fastStale, + 'mockAcquire' => $status, + 'mockRelease' => Status::newGood( PoolCounter::RELEASED ), ], ] ); } |