diff options
| author | Tim Starling <tstarling@wikimedia.org> | 2023-03-24 14:21:20 +1100 |
|---|---|---|
| committer | Krinkle <krinkle@fastmail.com> | 2023-03-25 00:39:06 +0000 |
| commit | be3018b268590a3c4523eb19d26891f323ab6115 (patch) | |
| tree | 6e25dbf00787dcc789d376e67bfcad66f817b5c2 /tests/phpunit/includes/libs/GenericArrayObjectTest.php | |
| parent | 317b460500725f81797d27c33bd68756055fb44c (diff) | |
| download | mediawikicore-be3018b268590a3c4523eb19d26891f323ab6115.tar.gz mediawikicore-be3018b268590a3c4523eb19d26891f323ab6115.zip | |
Just another 80 or so PHPStorm inspection fixes (#4)
* Unnecessary regex modifier. I agree with this inspection which flags
/s modifiers on regexes that don't use a dot.
* Property declared dynamically.
* Unused local variable. But it's acceptable for an unused local
variable to take the return value of a method under test, when it is
being tested for its side-effects. And it's acceptable for an unused
local variable to document unused list expansion elements, or the
nature of array keys in a foreach.
Change-Id: I067b5b45dd1138c00e7269b66d3d1385f202fe7f
Diffstat (limited to 'tests/phpunit/includes/libs/GenericArrayObjectTest.php')
| -rw-r--r-- | tests/phpunit/includes/libs/GenericArrayObjectTest.php | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/tests/phpunit/includes/libs/GenericArrayObjectTest.php b/tests/phpunit/includes/libs/GenericArrayObjectTest.php index a418a5eb7720..21aa3fa34973 100644 --- a/tests/phpunit/includes/libs/GenericArrayObjectTest.php +++ b/tests/phpunit/includes/libs/GenericArrayObjectTest.php @@ -175,7 +175,6 @@ abstract class GenericArrayObjectTest extends PHPUnit\Framework\TestCase { * @param callable $function */ protected function checkTypeChecks( $function ) { - $excption = null; $list = $this->getNew(); $elementClass = $list->getObjectType(); |