diff options
| author | Daimona Eaytoy <daimona.wiki@gmail.com> | 2021-03-20 16:18:58 +0100 |
|---|---|---|
| committer | Daimona Eaytoy <daimona.wiki@gmail.com> | 2021-04-16 20:15:00 +0200 |
| commit | 535d7abf592d671c22bfb8ba17c35ae1ff74c0a5 (patch) | |
| tree | 628ec543a5c64121cdaad15a8b51a3705355e1b7 /tests/phpunit/includes/filerepo/file/FileTest.php | |
| parent | 592bb57b31b89a3863671da2f26df4f95011ba7c (diff) | |
| download | mediawikicore-535d7abf592d671c22bfb8ba17c35ae1ff74c0a5.tar.gz mediawikicore-535d7abf592d671c22bfb8ba17c35ae1ff74c0a5.zip | |
phpunit: Mass-replace setMethods with onlyMethods and adjust
Ended up using
grep -Prl '\->setMethods\(' . | xargs sed -r -i 's/setMethods\(/onlyMethods\(/g'
special-casing setMethods( null ) -> onlyMethods( [] )
and then manual fix of failing test (from PS2 onwards).
Bug: T278010
Change-Id: I012dca7ae774bb430c1c44d50991ba0b633353f1
Diffstat (limited to 'tests/phpunit/includes/filerepo/file/FileTest.php')
| -rw-r--r-- | tests/phpunit/includes/filerepo/file/FileTest.php | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/tests/phpunit/includes/filerepo/file/FileTest.php b/tests/phpunit/includes/filerepo/file/FileTest.php index 76be387442ff..994518bba510 100644 --- a/tests/phpunit/includes/filerepo/file/FileTest.php +++ b/tests/phpunit/includes/filerepo/file/FileTest.php @@ -40,7 +40,7 @@ class FileTest extends MediaWikiMediaTestCase { $fileMock = $this->getMockBuilder( File::class ) ->setConstructorArgs( [ 'fileMock', false ] ) - ->setMethods( [ 'getWidth' ] ) + ->onlyMethods( [ 'getWidth' ] ) ->getMockForAbstractClass(); $fileMock->expects( $this->any() ) @@ -143,7 +143,7 @@ class FileTest extends MediaWikiMediaTestCase { $repoMock = $this->getMockBuilder( FileRepo::class ) ->setConstructorArgs( [ [ 'name' => 'repoMock', 'backend' => $backendMock ] ] ) - ->setMethods( [ 'fileExists', 'getLocalReference' ] ) + ->onlyMethods( [ 'fileExists', 'getLocalReference' ] ) ->getMock(); $tempDir = wfTempDir(); @@ -158,14 +158,14 @@ class FileTest extends MediaWikiMediaTestCase { ->will( $this->returnValue( $fsFile ) ); $handlerMock = $this->getMockBuilder( BitmapHandler::class ) - ->setMethods( [ 'supportsBucketing' ] )->getMock(); + ->onlyMethods( [ 'supportsBucketing' ] )->getMock(); $handlerMock->expects( $this->any() ) ->method( 'supportsBucketing' ) ->will( $this->returnValue( $data['supportsBucketing'] ) ); $fileMock = $this->getMockBuilder( File::class ) ->setConstructorArgs( [ 'fileMock', $repoMock ] ) - ->setMethods( [ 'getThumbnailBucket', 'getLocalRefPath', 'getHandler' ] ) + ->onlyMethods( [ 'getThumbnailBucket', 'getLocalRefPath', 'getHandler' ] ) ->getMockForAbstractClass(); $fileMock->expects( $this->any() ) @@ -262,17 +262,17 @@ class FileTest extends MediaWikiMediaTestCase { $repoMock = $this->getMockBuilder( FileRepo::class ) ->setConstructorArgs( [ [ 'name' => 'repoMock', 'backend' => $backendMock ] ] ) - ->setMethods( [ 'fileExists', 'getLocalReference' ] ) + ->onlyMethods( [ 'fileExists', 'getLocalReference' ] ) ->getMock(); $fileMock = $this->getMockBuilder( File::class ) ->setConstructorArgs( [ 'fileMock', $repoMock ] ) - ->setMethods( [ 'getWidth', 'getBucketThumbPath', 'makeTransformTmpFile', + ->onlyMethods( [ 'getWidth', 'getBucketThumbPath', 'makeTransformTmpFile', 'generateAndSaveThumb', 'getHandler' ] ) ->getMockForAbstractClass(); $handlerMock = $this->getMockBuilder( JpegHandler::class ) - ->setMethods( [ 'supportsBucketing' ] )->getMock(); + ->onlyMethods( [ 'supportsBucketing' ] )->getMock(); $handlerMock->expects( $this->any() ) ->method( 'supportsBucketing' ) ->will( $this->returnValue( true ) ); @@ -404,7 +404,7 @@ class FileTest extends MediaWikiMediaTestCase { public function testGetDisplayWidthHeight( $dim, $expected ) { $fileMock = $this->getMockBuilder( File::class ) ->setConstructorArgs( [ 'fileMock', false ] ) - ->setMethods( [ 'getWidth', 'getHeight' ] ) + ->onlyMethods( [ 'getWidth', 'getHeight' ] ) ->getMockForAbstractClass(); $fileMock->method( 'getWidth' )->willReturn( $dim[2] ); |