tests: Make some PHPUnit data providers static

Just methods where adding "static" to the declaration was enough, I
didn't do anything with providers that used $this.

Initially by search and replace. There were many mistakes which I
found mostly by running the PHPStorm inspection which searches for
$this usage in a static method. Later I used the PHPStorm "make static"
action which avoids the more obvious mistakes.

Bug: T332865
Change-Id: I47ed6692945607dfa5c139d42edbd934fa4f3a36

1 files changed, 2 insertions, 2 deletions

diff --git a/tests/phpunit/includes/exception/PermissionsErrorTest.php b/tests/phpunit/includes/exception/PermissionsErrorTest.php
index fdb29282bfdf..b5b40da2bdfb 100644
--- a/tests/phpunit/includes/exception/PermissionsErrorTest.php
+++ b/tests/phpunit/includes/exception/PermissionsErrorTest.php
@@ -12,7 +12,7 @@ class PermissionsErrorTest extends MediaWikiIntegrationTestCase {
 		$this->setGroupPermissions( '*', 'testpermission', true );
 	}
 
-	public function provideConstruction() {
+	public static function provideConstruction() {
 		$status = new PermissionStatus();
 		$status->error( 'cat', 1, 2 );
 		$status->warning( 'dog', 3, 4 );
@@ -32,7 +32,7 @@ class PermissionsErrorTest extends MediaWikiIntegrationTestCase {
 		$this->assertArrayEquals( $expected, $e->errors );
 	}
 
-	public function provideInvalidConstruction() {
+	public static function provideInvalidConstruction() {
 		yield [ null, null ];
 		yield [ null, [] ];
 		yield [ null, new PermissionStatus() ];