diff options
| author | Timo Tijhof <krinkle@fastmail.com> | 2023-07-25 01:54:03 +0100 |
|---|---|---|
| committer | Timo Tijhof <krinkle@fastmail.com> | 2023-07-25 01:54:03 +0100 |
| commit | 8c479bcca16b2970b741d73aa0188a444f57c08a (patch) | |
| tree | b8a2f93626081158a413ade1edd86754de4cd661 /tests/phpunit/includes/diff/TextDiffer | |
| parent | a99e31533b5cf85617a51630c98f4d4735686c4e (diff) | |
| download | mediawikicore-8c479bcca16b2970b741d73aa0188a444f57c08a.tar.gz mediawikicore-8c479bcca16b2970b741d73aa0188a444f57c08a.zip | |
context: Simplify RequestContext::getSkin() logic
I had to read this 5x to convince myself that it wouldn't discard
the assigned `$this->skin` object (from the elseif branch in the middle)
in the `if ( $skinName !== null )` branch below.
It appears to work fine, but it may be clearer to avoid the indirection
through checking that $skinName got assigned and rather move those
branches together.
This coincidentally matches the evaluation order of fetchSkinName().
Change-Id: Ia20136b8f04c8e8d89d29b97cdd99cb444c09838
Diffstat (limited to 'tests/phpunit/includes/diff/TextDiffer')
0 files changed, 0 insertions, 0 deletions