diff options
author | Timo Tijhof <krinkle@fastmail.com> | 2023-07-24 17:56:00 +0100 |
---|---|---|
committer | Bartosz DziewoĆski <matma.rex@gmail.com> | 2023-07-31 13:00:27 +0200 |
commit | e446a71f862399604c1cbaac3739f07e09e851bc (patch) | |
tree | 1efed5cf7f62b0e7724cc21aeb479747446123b2 /tests/phpunit/includes/diff/TextDiffer/Wikidiff2TextDifferTest.php | |
parent | c15aedabf8a69b043d6ac7fc50b8cd401e04a3ed (diff) | |
download | mediawikicore-e446a71f862399604c1cbaac3739f07e09e851bc.tar.gz mediawikicore-e446a71f862399604c1cbaac3739f07e09e851bc.zip |
ResourceLoader: Switch Resources.php to MW_INSTALL_PATH
Follows-up Ib4caa80bb700, which introduced MW_INSTALL_PATH as
alternative to $IP, but also introduced $wgBaseDirectory.
Its not clear to me whether we actually want/need $wgBaseDirectory
long-term as it introduces significant complexity for a distinction
that remains theoretical, not enforced, and lacking a use case.
But, at least here we don't need it as these all explicitly reference
files that are in the source tree. Mocking the path differently would
fail the tests.
There are some individual methods (OutputPage, used via SkinModule)
that do not make assumptions on file paths and work with any file
paths at runtime. Those indeed need $wgBaseDirectory for DI and
testability.
Change-Id: I56c28d36e2d7bbf7ec5a8f2f5ae99b291e7ee4e8
Diffstat (limited to 'tests/phpunit/includes/diff/TextDiffer/Wikidiff2TextDifferTest.php')
0 files changed, 0 insertions, 0 deletions