diff options
author | Amir Sarabadani <ladsgroup@gmail.com> | 2023-09-18 20:53:39 +0200 |
---|---|---|
committer | Amir Sarabadani <ladsgroup@gmail.com> | 2023-09-18 20:53:39 +0200 |
commit | dec0cf54a2186d9365af369eeea3e9bfff42020a (patch) | |
tree | 24812d95aa47b629e88248ccc6b6b0ac460ad7fe /tests/phpunit/includes/deferred | |
parent | 67b43aa02e89054b28bd6cf23810fcd10b6a37f7 (diff) | |
download | mediawikicore-dec0cf54a2186d9365af369eeea3e9bfff42020a.tar.gz mediawikicore-dec0cf54a2186d9365af369eeea3e9bfff42020a.zip |
tests: Migrate more easy cases to SQB
The script couldn't find these because they were using wfGetDb(). I
fixed that and that cleaned up a lot more.
Bug: T344971
Change-Id: I5c4c5fa65c42292bfb4d870936775e598fb30719
Diffstat (limited to 'tests/phpunit/includes/deferred')
-rw-r--r-- | tests/phpunit/includes/deferred/RefreshSecondaryDataUpdateTest.php | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/tests/phpunit/includes/deferred/RefreshSecondaryDataUpdateTest.php b/tests/phpunit/includes/deferred/RefreshSecondaryDataUpdateTest.php index 3dfac95e75ad..57883c3663ed 100644 --- a/tests/phpunit/includes/deferred/RefreshSecondaryDataUpdateTest.php +++ b/tests/phpunit/includes/deferred/RefreshSecondaryDataUpdateTest.php @@ -178,7 +178,10 @@ class RefreshSecondaryDataUpdateTest extends MediaWikiIntegrationTestCase { $reset = new ScopedCallback( [ $dbw, 'restoreFlags' ] ); $this->assertSame( 0, $dbw->trxLevel() ); - $dbw->selectRow( 'page', '*', '', __METHOD__ ); + $dbw->newSelectQueryBuilder() + ->select( '*' ) + ->from( 'page' ) + ->caller( __METHOD__ )->fetchRow(); if ( !$dbw->trxLevel() ) { $this->markTestSkipped( 'No implicit transaction, cannot test for T248003' ); } @@ -200,7 +203,10 @@ class RefreshSecondaryDataUpdateTest extends MediaWikiIntegrationTestCase { ->getMock(); $updater->method( 'getSecondaryDataUpdates' ) ->willReturnCallback( static function () use ( $dbw, $fname, $goodUpdate ) { - $dbw->selectRow( 'page', '*', '', $fname ); + $dbw->newSelectQueryBuilder() + ->select( '*' ) + ->from( 'page' ) + ->caller( $fname )->fetchRow(); $dbw->onTransactionResolution( static function () { }, $fname ); |