diff options
| author | Timo Tijhof <krinkle@fastmail.com> | 2023-08-25 00:38:02 +0100 |
|---|---|---|
| committer | Timo Tijhof <krinkle@fastmail.com> | 2023-09-09 20:42:02 +0100 |
| commit | e56552557f0da1260ea567c3c936f5c7a1a3c760 (patch) | |
| tree | a8b2149ace05f4c534ba0a053966d703eb92fc2e /tests/phpunit/includes/deferred/DeferredUpdatesTest.php | |
| parent | 47cdcbac8b3fbefb64b70319090c1add021d195b (diff) | |
| download | mediawikicore-e56552557f0da1260ea567c3c936f5c7a1a3c760.tar.gz mediawikicore-e56552557f0da1260ea567c3c936f5c7a1a3c760.zip | |
deferred: Decouple DeferredUpdates from MediaWikiServices
* Create task-specific methods with simple defaults that require no
mocking or stubbing of any kind, as used by the pure unit tests
where service container (and by extent, storage services) are
disabled.
* Remove all use of global variables, LBFactory, JobQueue,
StatsdFactory, and RequestContext.
Bug: T265749
Change-Id: If85c448d2d1b806e70f641f06263680d49c6eeec
Diffstat (limited to 'tests/phpunit/includes/deferred/DeferredUpdatesTest.php')
| -rw-r--r-- | tests/phpunit/includes/deferred/DeferredUpdatesTest.php | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/tests/phpunit/includes/deferred/DeferredUpdatesTest.php b/tests/phpunit/includes/deferred/DeferredUpdatesTest.php index 1ed7bdb8c2b8..d53cd1d7af9d 100644 --- a/tests/phpunit/includes/deferred/DeferredUpdatesTest.php +++ b/tests/phpunit/includes/deferred/DeferredUpdatesTest.php @@ -356,8 +356,7 @@ class DeferredUpdatesTest extends MediaWikiIntegrationTestCase { $called = true; }, $fname - ), - $lbFactory + ) ); $this->assertTrue( $called, "Callback ran" ); |