Merge "Emit deprecation warning for deprecated overrides."

1 files changed, 36 insertions, 0 deletions

diff --git a/tests/phpunit/includes/debug/MWDebugTest.php b/tests/phpunit/includes/debug/MWDebugTest.php
index 4e7e375b1b66..8734b523548d 100644
--- a/tests/phpunit/includes/debug/MWDebugTest.php
+++ b/tests/phpunit/includes/debug/MWDebugTest.php
@@ -51,6 +51,42 @@ class MWDebugTest extends MediaWikiIntegrationTestCase {
 	}
 
 	/**
+	 * @covers MWDebug::detectDeprecatedOverride
+	 */
+	public function testDetectDeprecatedOverride() {
+		$baseclassInstance = new TitleValue( NS_MAIN, 'Test' );
+
+		$this->assertFalse(
+			MWDebug::detectDeprecatedOverride(
+				$baseclassInstance,
+				TitleValue::class,
+				'getNamespace',
+				MW_VERSION
+			)
+		);
+
+		// create a dummy subclass that overrides a method
+		$subclassInstance = new class ( NS_MAIN, 'Test' ) extends TitleValue {
+			public function getNamespace() {
+				// never called
+				return -100;
+			}
+		};
+
+		$this->assertTrue(
+			MWDebug::detectDeprecatedOverride(
+				$subclassInstance,
+				TitleValue::class,
+				'getNamespace',
+				MW_VERSION
+			)
+		);
+
+		// A warning should have been logged
+		$this->assertCount( 1, MWDebug::getLog() );
+	}
+
+	/**
 	 * @covers MWDebug::deprecated
 	 */
 	public function testAvoidDuplicateDeprecations() {