Support abstraction for 'NOT IN' SQL structure

Following a live discussion with Catrope.

When using Database::makeList() in LIST_AND or LIST_OR modes, you can now
suffix the field name with an exclamation mark.  It will negate the logical
boolean.

Example:
  $db->makeList( array( 'field!' => array( 1,2,3 ) );
  outputs:
    'field' NOT IN ('1', '2', '3' );

 $db->makeList( array( 'foo!' => array( 777 ) ) );
 outputs:
   'foo' =! 777

(note: tests not ran, please run them and ammend them)

1 files changed, 28 insertions, 0 deletions

diff --git a/tests/phpunit/includes/db/DatabaseTest.php b/tests/phpunit/includes/db/DatabaseTest.php
index 7357524f28d2..5fac8dceef23 100644
--- a/tests/phpunit/includes/db/DatabaseTest.php
+++ b/tests/phpunit/includes/db/DatabaseTest.php
@@ -90,6 +90,34 @@ class DatabaseTest extends MediaWikiTestCase {
 			$sql );
 	}
 
+	function testMakeNotInList() {
+		$this->assertEquals(
+			$this->db->makeList( array(
+				'field' => array( 0, 1 )
+			) ),
+			"field IN ('0','1')"
+		);
+		$this->assertEquals(
+			$this->db->makeList( array(
+				'field!' => array( 0, 1 )
+			) ),
+			"field NOT IN ('0','1')"
+		);
+
+		// make sure an array with only one value use = or !=
+		$this->assertEquals(
+			$this->db->makeList( array(
+				'field' => array( 777 )
+			) ),
+			"field = 777"
+		);
+		$this->assertEquals(
+			$this->db->makeList( array(
+				'field!' => array( 888 )
+			) ),
+			"field != 888"
+		);
+	}
 }