aboutsummaryrefslogtreecommitdiffstats
path: root/tests/phpunit/includes/db/DatabaseSQLTest.php
diff options
context:
space:
mode:
authorAaron Schulz <aschulz@wikimedia.org>2016-09-15 20:14:58 -0700
committerAaron Schulz <aschulz@wikimedia.org>2016-09-17 03:38:05 +0000
commit403a1ea17835664a4d45269fe9cd4bde5797616b (patch)
treecaf1d9ce0cf2ebea962b3ae666151e9badce3038 /tests/phpunit/includes/db/DatabaseSQLTest.php
parent2f90b6f00a3bf4fd3686538d33475063754ea349 (diff)
downloadmediawikicore-403a1ea17835664a4d45269fe9cd4bde5797616b.tar.gz
mediawikicore-403a1ea17835664a4d45269fe9cd4bde5797616b.zip
Move all of the reasonable DatabaseBase methods to Database class
The Database class was previously just a short-hand for "Database::", and such calls should still work. The class now resides in /libs/rdbms. The subclasses now extend DatabaseBase to avoid breaking type hints that use that (hints use either IDatabase or DatabaseBase). Also, use CASCADE with DROP TABLE for MySQL as with other DBs. Keep SQLite excempt due to lack of support. Added getDomainID() methods to avoid mentioning the word "wiki". Change-Id: Ibd05d786cb26c21dcc9cb9601f6b2b52056af9ae
Diffstat (limited to 'tests/phpunit/includes/db/DatabaseSQLTest.php')
-rw-r--r--tests/phpunit/includes/db/DatabaseSQLTest.php2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/phpunit/includes/db/DatabaseSQLTest.php b/tests/phpunit/includes/db/DatabaseSQLTest.php
index e7eeff94295f..0013685184d7 100644
--- a/tests/phpunit/includes/db/DatabaseSQLTest.php
+++ b/tests/phpunit/includes/db/DatabaseSQLTest.php
@@ -736,7 +736,7 @@ class DatabaseSQLTest extends MediaWikiTestCase {
public function testDropTable() {
$this->database->setExistingTables( [ 'table' ] );
$this->database->dropTable( 'table', __METHOD__ );
- $this->assertLastSql( 'DROP TABLE table' );
+ $this->assertLastSql( 'DROP TABLE table CASCADE' );
}
/**