Push pagination decision for search into SearchEngine

Various code using the search engine shouldn't need to implement it's
own methods, such as over-fetching, to determine if there are more
results available. This should be knowledge internal to search that is
exposed by a boolean.

Change-Id: Ica094428700637dfdedb723b03f6aeadfe12b9f4

1 files changed, 48 insertions, 0 deletions

diff --git a/tests/phpunit/includes/api/ApiQueryPrefixSearchTest.php b/tests/phpunit/includes/api/ApiQueryPrefixSearchTest.php
new file mode 100644
index 000000000000..ae5924d80056
--- /dev/null
+++ b/tests/phpunit/includes/api/ApiQueryPrefixSearchTest.php
@@ -0,0 +1,48 @@
+<?php
+
+/**
+ * @group API
+ * @group medium
+ *
+ * @covers ApiQueryPrefixSearch
+ */
+class ApiQueryPrefixSearchTest extends ApiTestCase {
+	public function offsetContinueProvider() {
+		return [
+			'no offset' => [ 2, 2, 0, 2 ],
+			'with offset' => [ 7, 2, 5, 2 ],
+			'past end, no offset' => [ null, 11, 0, 20 ],
+			'past end, with offset' => [ null, 5, 6, 10 ],
+		];
+	}
+
+	/**
+	 * @dataProvider offsetContinueProvider
+	 */
+	public function testOffsetContinue( $expectedOffset, $expectedResults, $offset, $limit ) {
+		$this->registerMockSearchEngine();
+		$response = $this->doApiRequest( [
+			'action' => 'query',
+			'list' => 'prefixsearch',
+			'pssearch' => 'example query terms',
+			'psoffset' => $offset,
+			'pslimit' => $limit,
+		] );
+		$result = $response[0];
+		$this->assertArrayNotHasKey( 'warnings', $result );
+		$suggestions = $result['query']['prefixsearch'];
+		$this->assertCount( $expectedResults, $suggestions );
+		if ( $expectedOffset == null ) {
+			$this->assertArrayNotHasKey( 'continue', $result );
+		} else {
+			$this->assertArrayHasKey( 'continue', $result );
+			$this->assertEquals( $expectedOffset, $result['continue']['psoffset'] );
+		}
+	}
+
+	private function registerMockSearchEngine() {
+		$this->setMwGlobals( [
+			'wgSearchType' => MockCompletionSearchEngine::class,
+		] );
+	}
+}