PageUpdatedEvent: improve modeling of flags

Why:
- Improve consistency, naming, documentation and definition of flags.

What:
- remove direct access to flags, provide a separate getter for each flag
  instead.
- Deprecate EDIT_SUPPRESS_RC in favor of EDIT_SILENT
- Introduce EDIT_IMPLICIT to replace "automated" mode
- Introduce FLAG_RECONCILIATION_REQUEST into PageEvent.
- Introduce isReconciliationRequest into DomainEvent.

Bug: T383552
Change-Id: I2bffbb5810376829f871e1840ca799a8d8232dda

1 files changed, 3 insertions, 3 deletions

diff --git a/tests/phpunit/includes/api/ApiImportTest.php b/tests/phpunit/includes/api/ApiImportTest.php
index 11b0cecc688c..effc66ed9fe6 100644
--- a/tests/phpunit/includes/api/ApiImportTest.php
+++ b/tests/phpunit/includes/api/ApiImportTest.php
@@ -53,16 +53,16 @@ class ApiImportTest extends ApiUploadTestCase {
 				);
 
 				Assert::assertTrue( $event->isSilent(), 'isSilent' );
-				Assert::assertTrue( $event->isAutomated(), 'isAutomated' );
+				Assert::assertTrue( $event->isImplicit(), 'isImplicit' );
 
 				if ( $calls === 1 ) {
 					// First call, from ImportableOldRevisionImporter
-					Assert::assertTrue( $event->isNew(), 'isNew' );
+					Assert::assertTrue( $event->isCreation(), 'isCreation' );
 					Assert::assertTrue( $event->isRevisionChange(), 'isRevisionChange' );
 					Assert::assertTrue( $event->isContentChange(), 'isContentChange' );
 				} else {
 					// Second call, from ApiImportReporter
-					Assert::assertFalse( $event->isNew(), 'isNew' );
+					Assert::assertFalse( $event->isCreation(), 'isCreation' );
 					Assert::assertTrue( $event->isRevisionChange(), 'isRevisionChange' );
 					Assert::assertFalse( $event->isContentChange(), 'isContentChange' );
 				}