tests: Make some PHPUnit data providers static

Just methods where adding "static" to the declaration was enough, I
didn't do anything with providers that used $this.

Initially by search and replace. There were many mistakes which I
found mostly by running the PHPStorm inspection which searches for
$this usage in a static method. Later I used the PHPStorm "make static"
action which avoids the more obvious mistakes.

Bug: T332865
Change-Id: I47ed6692945607dfa5c139d42edbd934fa4f3a36

1 files changed, 3 insertions, 3 deletions

diff --git a/tests/phpunit/includes/XmlTest.php b/tests/phpunit/includes/XmlTest.php
index 3c190d5ad5d3..880b82d8d99b 100644
--- a/tests/phpunit/includes/XmlTest.php
+++ b/tests/phpunit/includes/XmlTest.php
@@ -40,7 +40,7 @@ class XmlTest extends MediaWikiIntegrationTestCase {
 		$this->setUserLang( $langObj );
 	}
 
-	public function provideElement() {
+	public static function provideElement() {
 		// $expect, $element, $attribs, $contents
 		yield 'Opening element with no attributes' => [ '<element>', 'element', null, null ];
 		yield 'Terminated empty element' => [ '<element />', 'element', null, '' ];
@@ -98,7 +98,7 @@ class XmlTest extends MediaWikiIntegrationTestCase {
 		$this->assertEquals( '</element>', Xml::closeElement( 'element' ), 'closeElement() shortcut' );
 	}
 
-	public function provideMonthSelector() {
+	public static function provideMonthSelector() {
 		# providers are run before services are set up
 		$lang = new class() {
 			public function getMonthName( $i ) {
@@ -430,7 +430,7 @@ class XmlTest extends MediaWikiIntegrationTestCase {
 		);
 	}
 
-	public function provideFieldset() {
+	public static function provideFieldset() {
 		// $expect, [ $arg1, $arg2, ... ]
 		yield 'Opening tag' => [ "<fieldset>\n", [] ];
 		yield 'Opening tag (false means no legend)' => [ "<fieldset>\n", [ false ] ];