Remove unneeded creation of revision objects

Clean up some technical debt; use MutableRevisionRecord instead of
manually constructing a Revision from an array, remove last uses of
RevisionStoreDbTestBase::revisionToRow and remove the method.

Each file can be reviewed separately (except that the removal of
revisionToRow depends on replacing its usage)

Bug: T246284
Change-Id: I0bdc069b21a5c41ef8f9e972c5b17ff189d4a741

1 files changed, 8 insertions, 14 deletions

diff --git a/tests/parser/ParserTestRunner.php b/tests/parser/ParserTestRunner.php
index 748fb561218c..04761c2f4a5a 100644
--- a/tests/parser/ParserTestRunner.php
+++ b/tests/parser/ParserTestRunner.php
@@ -27,6 +27,8 @@
  */
 
 use MediaWiki\MediaWikiServices;
+use MediaWiki\Revision\MutableRevisionRecord;
+use MediaWiki\Revision\SlotRecord;
 use Wikimedia\Rdbms\IDatabase;
 use Wikimedia\ScopedCallback;
 use Wikimedia\TestingAccessWrapper;
@@ -843,20 +845,12 @@ class ParserTestRunner {
 				'page_is_redirect' => 0
 			] );
 
-			// TODO construct a RevisionRecord here instead
-			$rev = new Revision(
-				[
-					'id' => $title->getLatestRevID(),
-					'page' => $title->getArticleID(),
-					'user' => $user,
-					'content' => $content,
-					'timestamp' => $this->getFakeTimestamp(),
-					'title' => $title
-				],
-				Revision::READ_LATEST,
-				$title
-			);
-			$revRecord = $rev->getRevisionRecord();
+			$revRecord = new MutableRevisionRecord( $title );
+			$revRecord->setContent( SlotRecord::MAIN, $content );
+			$revRecord->setUser( $user );
+			$revRecord->setTimestamp( strval( $this->getFakeTimestamp() ) );
+			$revRecord->setPageId( $title->getArticleID() );
+			$revRecord->setId( $title->getLatestRevID() );
 
 			$oldCallback = $options->getCurrentRevisionRecordCallback();
 			$options->setCurrentRevisionRecordCallback(