Merge "DeduplicateStyles: Only transform possible style nodes"HEADmaster

1 files changed, 33 insertions, 9 deletions

diff --git a/tests/phpunit/includes/OutputTransform/Stages/DeduplicateStylesTest.php b/tests/phpunit/includes/OutputTransform/Stages/DeduplicateStylesTest.php
index eae21cbbedcd..45c5a4d629ec 100644
--- a/tests/phpunit/includes/OutputTransform/Stages/DeduplicateStylesTest.php
+++ b/tests/phpunit/includes/OutputTransform/Stages/DeduplicateStylesTest.php
@@ -35,8 +35,12 @@ class DeduplicateStylesTest extends OutputTransformStageTestBase {
 		] );
 	}
 
-	public function provideTransform(): array {
-		$dedup = <<<EOF
+	public function provideTransform(): iterable {
+		$testCases = [
+			'legacy parser output' => [
+				TestUtils::TEST_TO_DEDUP,
+				[],
+				<<<EOF
 <p>This is a test document.</p>
 <style data-mw-deduplicate="duplicate1">.Duplicate1 {}</style>
 <link rel="mw-deduplicated-inline-style" href="mw-data:duplicate1" />
@@ -47,13 +51,33 @@ class DeduplicateStylesTest extends OutputTransformStageTestBase {
 <link rel="mw-deduplicated-inline-style" href="mw-data:duplicate1" />
 <style data-mw-deduplicate="duplicate3">.Duplicate1 {}</style>
 <style>.Duplicate1 {}</style>
-EOF;
-
-		$po = new ParserOutput( TestUtils::TEST_TO_DEDUP );
-		$expected = new ParserOutput( $dedup );
-		$opts = [];
-		return [
-			[ $po, null, $opts, $expected ]
+EOF
+			],
+			'parsoid content with encoded style tags in data-mw attribute' => [
+				<<<EOF
+<style data-mw-deduplicate="duplicate1">.Duplicate1 {}</style>
+<span data-mw="{&quot;name&quot;:&quot;ref&quot;,&quot;attrs&quot;:{&quot;name&quot;:&quot;blank&quot;},
+&quot;body&quot;:{&quot;html&quot;:&quot;<style data-mw-deduplicate=\&quot;duplicate1\&quot;>.Duplicate1 {}</style>&quot;}"></span>
+<style data-mw-deduplicate="duplicate1">.Duplicate1 {}</style>
+EOF
+				,
+				[ 'isParsoidContent' => true ],
+				<<<EOF
+<style data-mw-deduplicate="duplicate1">.Duplicate1 {}</style>
+<span data-mw="{&quot;name&quot;:&quot;ref&quot;,&quot;attrs&quot;:{&quot;name&quot;:&quot;blank&quot;},
+&quot;body&quot;:{&quot;html&quot;:&quot;<style data-mw-deduplicate=\&quot;duplicate1\&quot;>.Duplicate1 {}</style>&quot;}"></span>
+<link rel="mw-deduplicated-inline-style" href="mw-data:duplicate1">
+EOF
+			]
 		];
+
+		foreach ( $testCases as $name => [ $input, $options, $expected ] ) {
+			yield $name => [
+				new ParserOutput( $input ),
+				null,
+				$options,
+				new ParserOutput( $expected )
+			];
+		}
 	}
 }