diff options
| author | Ed Sanders <esanders@wikimedia.org> | 2017-10-03 15:52:13 +0100 |
|---|---|---|
| committer | Ed Sanders <esanders@wikimedia.org> | 2017-10-03 15:52:49 +0100 |
| commit | 25e87732f8e36b9004071368e0bcc1298b6677e9 (patch) | |
| tree | d5445dfb82551efa676ed8e7e67825beca132650 /resources/src/mediawiki.widgets | |
| parent | 89af348547bcde0c44868ea0902f1dc6054d2d74 (diff) | |
| download | mediawikicore-25e87732f8e36b9004071368e0bcc1298b6677e9.tar.gz mediawikicore-25e87732f8e36b9004071368e0bcc1298b6677e9.zip | |
TitleOptionWidget: Don't show an icon when showImages=false
Change-Id: Ib4262bc15a3845ec9e7af484dbdfa4277f2f4014
Diffstat (limited to 'resources/src/mediawiki.widgets')
| -rw-r--r-- | resources/src/mediawiki.widgets/mw.widgets.TitleOptionWidget.js | 7 | ||||
| -rw-r--r-- | resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js | 1 |
2 files changed, 6 insertions, 2 deletions
diff --git a/resources/src/mediawiki.widgets/mw.widgets.TitleOptionWidget.js b/resources/src/mediawiki.widgets/mw.widgets.TitleOptionWidget.js index 0f1815b00483..638f461ba783 100644 --- a/resources/src/mediawiki.widgets/mw.widgets.TitleOptionWidget.js +++ b/resources/src/mediawiki.widgets/mw.widgets.TitleOptionWidget.js @@ -16,6 +16,7 @@ * @param {Object} config Configuration options * @cfg {string} data Label to display * @cfg {string} url URL of page + * @cfg {boolean} [showImages] Whether to attempt to show images * @cfg {string} [imageUrl] Thumbnail image URL with URL encoding * @cfg {string} [description] Page description * @cfg {boolean} [missing] Page doesn't exist @@ -26,7 +27,9 @@ mw.widgets.TitleOptionWidget = function MwWidgetsTitleOptionWidget( config ) { var icon; - if ( config.missing ) { + if ( !config.showImages ) { + icon = null; + } else if ( config.missing ) { icon = 'page-not-found'; } else if ( config.redirect ) { icon = 'page-redirect'; @@ -78,7 +81,7 @@ this.$label.addClass( 'mw-disambig' ); } - if ( config.imageUrl ) { + if ( config.showImages && config.imageUrl ) { this.$icon .addClass( 'mw-widget-titleOptionWidget-hasImage' ) .css( 'background-image', 'url(' + config.imageUrl + ')' ); diff --git a/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js b/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js index 8e7afd7f1970..5fe094ff63e0 100644 --- a/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js +++ b/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js @@ -329,6 +329,7 @@ mwTitle.getRelativeText( this.namespace ) : title, url: mwTitle.getUrl(), + showImages: this.showImages, imageUrl: this.showImages ? data.imageUrl : null, description: this.showDescriptions ? description : null, missing: data.missing, |