diff options
author | Daniel Friesen <dantman@users.mediawiki.org> | 2011-08-12 09:27:16 +0000 |
---|---|---|
committer | Daniel Friesen <dantman@users.mediawiki.org> | 2011-08-12 09:27:16 +0000 |
commit | 7e8f5f1e8f6b0de969bb5da76c5879af5bd43b75 (patch) | |
tree | 45c2137b1e5233c59952ef71c27804c440a9fff6 /resources/mediawiki/mediawiki.util.js | |
parent | 033b9cd5e2b465697bb5733acaddbe3db267a881 (diff) | |
download | mediawikicore-7e8f5f1e8f6b0de969bb5da76c5879af5bd43b75.tar.gz mediawikicore-7e8f5f1e8f6b0de969bb5da76c5879af5bd43b75.zip |
Fix usage of the jQuery global in a few spots.
- jQuery changed to $ in some files because there is a closure that creates a locally scoped $, but the jQuery var is globally scoped, meaning using jQuery instead of $ inside that closure could result in interacting with a different instance of jQuery than the uses of $ in that same closure.
- In mwExtension wrap the code inside a closure which it is missing. Also take this chance to fix the whitespace style `fn( arg )` instead of `fn(arg)` on the isArray I added.
This is partially a followup to r94331.
Note: The jquery plugins inside the jquery/ folder look fine for use of jQuery within closures, except for mockjax.
Notes
Notes:
http://mediawiki.org/wiki/Special:Code/MediaWiki/94332
Diffstat (limited to 'resources/mediawiki/mediawiki.util.js')
-rw-r--r-- | resources/mediawiki/mediawiki.util.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/resources/mediawiki/mediawiki.util.js b/resources/mediawiki/mediawiki.util.js index a720f58333e4..e6bb9fb6ff6c 100644 --- a/resources/mediawiki/mediawiki.util.js +++ b/resources/mediawiki/mediawiki.util.js @@ -267,7 +267,7 @@ return; - } else if ( nodeList instanceof jQuery ) { + } else if ( nodeList instanceof $ ) { $nodes = nodeList; } else { $nodes = $( nodeList ); |