Kranitor #2: Pass JSHint on resources/mediawiki/*

* .jshintrc
 - Update properties to reflect our conventions more

* Re-pass resources/jquery/*
* Pass resources/mediawiki/*
 - Trailing whitespace
 - Whitelist the one usage of document.write with
   a local /*jshint evil:true */ in the function that
   we allow to use it.
 - Get rid of dangling _ in var names and undescriptive
   instances of '_this'.
 - More code conventions

* Add a few documentation comments while at it

Change-Id: Ic4f2b5d473a440667a40e4d5f12f40877386b02f

1 files changed, 29 insertions, 25 deletions

diff --git a/resources/mediawiki.special/mediawiki.special.javaScriptTest.js b/resources/mediawiki.special/mediawiki.special.javaScriptTest.js
index d413f602cb8b..808d5fe89f29 100644
--- a/resources/mediawiki.special/mediawiki.special.javaScriptTest.js
+++ b/resources/mediawiki.special/mediawiki.special.javaScriptTest.js
@@ -1,33 +1,37 @@
-/*
+/**
  * JavaScript for Special:JavaScriptTest
  */
-jQuery( document ).ready( function( $ ) {
+( function ( mw, $ ) {
+	$( function () {
 
-	// Create useskin dropdown menu and reload onchange to the selected skin
-	// (only if a framework was found, not on error pages).
-	$( '#mw-javascripttest-summary.mw-javascripttest-frameworkfound' ).append( function() {
+		// Create useskin dropdown menu and reload onchange to the selected skin
+		// (only if a framework was found, not on error pages).
+		$( '#mw-javascripttest-summary.mw-javascripttest-frameworkfound' ).append( function () {
 
-		var	$html = $( '<p><label for="useskin">'
-				+ mw.message( 'javascripttest-pagetext-skins' ).escaped()
-				+ ' '
-				+ '</label></p>' ),
-			select = '<select name="useskin" id="useskin">';
+			var	$html = $( '<p><label for="useskin">'
+					+ mw.message( 'javascripttest-pagetext-skins' ).escaped()
+					+ ' '
+					+ '</label></p>' ),
+				select = '<select name="useskin" id="useskin">';
 
-		// Build <select> further
-		$.each( mw.config.get( 'wgAvailableSkins' ), function( id ) {
-			select += '<option value="' + id + '"'
-				+ ( mw.config.get( 'skin' ) === id ? ' selected="selected"' : '' )
-				+ '>' + mw.message( 'skinname-' + id ).escaped() + '</option>';
-		} );
-		select += '</select>';
+			// Build <select> further
+			$.each( mw.config.get( 'wgAvailableSkins' ), function ( id ) {
+				select += '<option value="' + id + '"'
+					+ ( mw.config.get( 'skin' ) === id ? ' selected="selected"' : '' )
+					+ '>' + mw.message( 'skinname-' + id ).escaped() + '</option>';
+			} );
+			select += '</select>';
 
-		// Bind onchange event handler and append to form
-		$html.append(
-			$( select ).change( function() {
-				window.location = QUnit.url( { useskin: $(this).val() } );
-			} )
-		);
+			// Bind onchange event handler and append to form
+			$html.append(
+				$( select ).change( function () {
+					window.location = QUnit.url( { useskin: $(this).val() } );
+				} )
+			);
 
-		return $html;
+			return $html;
+		} );
 	} );
-} );
+
+}( mediaWiki, jQuery ) );
+