diff options
| author | Brad Jorsch <bjorsch@wikimedia.org> | 2017-10-12 14:34:15 -0400 |
|---|---|---|
| committer | Anomie <bjorsch@wikimedia.org> | 2017-10-13 19:02:56 +0000 |
| commit | fa4a909def47f176f9c3f732a32e8cad3a8a50d5 (patch) | |
| tree | 6e0e6f73dfb164e2ce424702a31600d2fb9d4575 /maintenance/storage | |
| parent | 022dd24850dc3bdb92dc1bb534b1a649fc906fea (diff) | |
| download | mediawikicore-fa4a909def47f176f9c3f732a32e8cad3a8a50d5.tar.gz mediawikicore-fa4a909def47f176f9c3f732a32e8cad3a8a50d5.zip | |
Replace more uses of "SELECT *"
With the introduction of CommentStore, selects from various table
require certain joins or column aliases for proper operation. The
upcoming actor table change, and the suggested title table change, will
add more such requirements.
Change-Id: Ic8213bff74b8350b15cd271d0ef252e63e7e79bd
Diffstat (limited to 'maintenance/storage')
| -rw-r--r-- | maintenance/storage/testCompression.php | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/maintenance/storage/testCompression.php b/maintenance/storage/testCompression.php index 90d8d0311070..deb2ca60d55a 100644 --- a/maintenance/storage/testCompression.php +++ b/maintenance/storage/testCompression.php @@ -50,7 +50,11 @@ $type = isset( $options['type'] ) ? $options['type'] : 'ConcatenatedGzipHistoryB $dbr = $this->getDB( DB_REPLICA ); $res = $dbr->select( [ 'page', 'revision', 'text' ], - '*', + array_merge( + Revision::selectFields(), + Revision::selectPageFields(), + Revision::selectTextFields() + ), [ 'page_namespace' => $title->getNamespace(), 'page_title' => $title->getDBkey(), |