diff options
| author | Umherirrender <umherirrender_de.wp@web.de> | 2022-03-29 20:11:06 +0200 |
|---|---|---|
| committer | Umherirrender <umherirrender_de.wp@web.de> | 2022-03-30 19:47:15 +0000 |
| commit | 6caf78c2c8eb0b629effd29350879d0b5feb60e5 (patch) | |
| tree | 66bee346941e501e565d8db47bc26375d4318581 /maintenance/populatePPSortKey.php | |
| parent | 0bbb64d8b847e347861b56df95e292cbca8fabd1 (diff) | |
| download | mediawikicore-6caf78c2c8eb0b629effd29350879d0b5feb60e5.tar.gz mediawikicore-6caf78c2c8eb0b629effd29350879d0b5feb60e5.zip | |
phan: Remove PhanPossiblyUndeclaredVariable suppression
Make phan stricter about conditional variable declaration
Remaining false positive issues are suppressed.
The suppression and the setting change can only be done together
Bug: T259172
Change-Id: I1f200ac37df7448453688bf464a8250c97313e5d
Diffstat (limited to 'maintenance/populatePPSortKey.php')
| -rw-r--r-- | maintenance/populatePPSortKey.php | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/maintenance/populatePPSortKey.php b/maintenance/populatePPSortKey.php index 497277bad1b8..76f38f783083 100644 --- a/maintenance/populatePPSortKey.php +++ b/maintenance/populatePPSortKey.php @@ -93,8 +93,10 @@ class PopulatePPSortKey extends LoggedUpdateMaintenance { $this->commitTransaction( $dbw, __METHOD__ ); // We need to get the last element's page ID + // @phan-suppress-next-line PhanPossiblyUndeclaredVariable rows contains at least one item $lastPageValue = $row->pp_page; // And the propname... + // @phan-suppress-next-line PhanPossiblyUndeclaredVariable rows contains at least one item $lastProp = $row->pp_propname; } |