diff options
author | Timo Tijhof <krinklemail@gmail.com> | 2013-05-08 01:00:15 +0200 |
---|---|---|
committer | Timo Tijhof <krinklemail@gmail.com> | 2013-05-09 05:56:26 +0200 |
commit | 50e7985d4d5e9f70bd27e61d84d43514004f23da (patch) | |
tree | a0c9334b0841dc68992d0dfa6fa6aedb15d2c00d /maintenance/nextJobDB.php | |
parent | ee85aac6ffb80b290f6d7794bf1d9d76f40e5de5 (diff) | |
download | mediawikicore-50e7985d4d5e9f70bd27e61d84d43514004f23da.tar.gz mediawikicore-50e7985d4d5e9f70bd27e61d84d43514004f23da.zip |
phpcs: Fix WhiteSpace.LanguageConstructSpacing warnings
Squiz.WhiteSpace.LanguageConstructSpacing:
Language constructs must be followed by a single space;
expected "require_once expression" but found
"require_once(expression)"
It is a keyword (e.g. like `new`, `return` and `print`). As
such the parentheses don't make sense.
Per our code conventions, we use a space after keywords like
these. We appeared to have an unwritten exception for `require`
that doesn't make sense. About 60% of require/include usage
was missing the space and/or had superfluous parentheses.
It is as silly as print("foo") or return("foo"), it works
because keywords have no significance for whitespace between
it and the expression that follows, and since experessions can
be wrapped in parentheses for clarity (e.g. when doing string
concatenation or mathematical operations) the parenthesis
before and after basiclaly just ignored.
Change-Id: I2df2f80b8123714bea7e0771bf94b51ad5bb4b87
Diffstat (limited to 'maintenance/nextJobDB.php')
-rw-r--r-- | maintenance/nextJobDB.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/maintenance/nextJobDB.php b/maintenance/nextJobDB.php index 1be5146eb2ca..ca550ae9d375 100644 --- a/maintenance/nextJobDB.php +++ b/maintenance/nextJobDB.php @@ -116,4 +116,4 @@ class nextJobDB extends Maintenance { } $maintClass = "nextJobDb"; -require_once( RUN_MAINTENANCE_IF_MAIN ); +require_once RUN_MAINTENANCE_IF_MAIN; |