diff options
| author | Amir Sarabadani <Ladsgroup@gmail.com> | 2020-05-09 15:53:35 +0200 |
|---|---|---|
| committer | Amir Sarabadani <Ladsgroup@gmail.com> | 2020-05-09 16:08:44 +0200 |
| commit | dbbb3af6dc7dfd2d1299b5146fc60c3047c7e9ce (patch) | |
| tree | bf56b3b37006334d4291c91025a1b40626504947 /maintenance/generateSchemaSql.php | |
| parent | a95577a0ee69d9faa21dbd567f45f6901b05b8bd (diff) | |
| download | mediawikicore-dbbb3af6dc7dfd2d1299b5146fc60c3047c7e9ce.tar.gz mediawikicore-dbbb3af6dc7dfd2d1299b5146fc60c3047c7e9ce.zip | |
Small improvements to DoctrineSchemaBuilder and generateSchemaSql
Adding scope to const, adding docstring, adding comments to generated
files, fix default path.
Bug: T230428
Change-Id: I955a446421ffe5c8fa42aeedc0f962230e92e02a
Diffstat (limited to 'maintenance/generateSchemaSql.php')
| -rw-r--r-- | maintenance/generateSchemaSql.php | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/maintenance/generateSchemaSql.php b/maintenance/generateSchemaSql.php index 5caaf64aac64..1ce4a13441b7 100644 --- a/maintenance/generateSchemaSql.php +++ b/maintenance/generateSchemaSql.php @@ -57,8 +57,8 @@ class GenerateSchemaSql extends Maintenance { } public function execute() { - $jsonFile = $this->getOption( 'json', 'tables.json' ); - $sqlFile = $this->getOption( 'sql', 'tables-generated.sql' ); + $jsonFile = $this->getOption( 'json', __DIR__ . '/tables.json' ); + $sqlFile = $this->getOption( 'sql', __DIR__ . '/tables-generated.sql' ); $abstractSchema = json_decode( file_get_contents( $jsonFile ), true ); $schemaBuilder = ( new DoctrineSchemaBuilderFactory() )->getSchemaBuilder( $this->getOption( 'type', 'mysql' ) @@ -66,7 +66,10 @@ class GenerateSchemaSql extends Maintenance { foreach ( $abstractSchema as $table ) { $schemaBuilder->addTable( $table ); } - file_put_contents( $sqlFile, $schemaBuilder->getSql() ); + $sql = "-- This file is automatically generated using maintenance/generateSchemaSql.php.\n" . + "-- Do not modify this file directly.\n" . + "-- See https://www.mediawiki.org/wiki/Manual:Schema_changes\n"; + file_put_contents( $sqlFile, $sql . implode( ";\n\n", $schemaBuilder->getSql() ) . ';' ); } } |