diff options
| author | Thiemo Kreuz <thiemo.kreuz@wikimedia.de> | 2019-02-28 09:55:50 +0100 |
|---|---|---|
| committer | Umherirrender <umherirrender_de.wp@web.de> | 2019-03-01 17:17:40 +0000 |
| commit | 007bfbf83578df5010415d5822c6aec057ffaa88 (patch) | |
| tree | e5f9cbdf3cf0571a6d34eacc0d4bfd00f7004a2c /maintenance/Maintenance.php | |
| parent | 9b4461c1b8027049d575bc66b45a1545bd506188 (diff) | |
| download | mediawikicore-007bfbf83578df5010415d5822c6aec057ffaa88.tar.gz mediawikicore-007bfbf83578df5010415d5822c6aec057ffaa88.zip | |
maintenance: Add missing limit parameters to some explode()
This is, in theory, a loophole that can not only cause such code to
consume suprising amounts of memory and runtime. It can also create
suprising results. For example, an input like
-param="might contain a = char"
might result in a cut-off value.
Not so much of a problem in a maintenance script. But still good
practice, I find.
Change-Id: I14fb278e6fdb61d0c486ca7e23229851ea479408
Diffstat (limited to 'maintenance/Maintenance.php')
| -rw-r--r-- | maintenance/Maintenance.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/maintenance/Maintenance.php b/maintenance/Maintenance.php index f3c2e12da22e..b638b42dff56 100644 --- a/maintenance/Maintenance.php +++ b/maintenance/Maintenance.php @@ -1251,7 +1251,7 @@ abstract class Maintenance { $settingsFile = "$IP/LocalSettings.php"; } if ( isset( $this->mOptions['wiki'] ) ) { - $bits = explode( '-', $this->mOptions['wiki'] ); + $bits = explode( '-', $this->mOptions['wiki'], 2 ); if ( count( $bits ) == 1 ) { $bits[] = ''; } |