Modernize status and error message handling

* Use pretty error boxes instead of 'error' CSS class.
* Use Status::getMessages() and display each error individually,
  instead of getWikiText(). The latter sometimes messes up the display
  of complex messages, such as customized AbuseFilter errors.
* Add missing 'mediawiki.codex.messagebox.styles' (some of these pages
  already used pretty error boxes in other code paths).
* Other minor fixes.

Bug: T377384
Bug: T375287
Change-Id: If2299f98f23e9ad057bce56260e264507337e0b6

2 files changed, 0 insertions, 6 deletions

diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index 2bad3295a213..f3f817a8e195 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -2536,7 +2536,6 @@
 	"undelete-comment-dropdown-unsuppress": "",
 	"undelete-edit-commentlist": "Edit undelete reasons",
 	"undelete-edit-commentlist-unsuppress": "Edit unsuppress reasons",
-	"cannotundelete": "Some or all of the undeletion failed:\n$1",
 	"undeletedpage": "<strong>$1 has been undeleted</strong>\n\nConsult the [[Special:Log/delete|deletion log]] for a record of recent deletions and restorations.",
 	"undelete-header": "See [[Special:Log/delete|the deletion log]] for recently deleted pages.",
 	"undelete-search-title": "Search deleted pages",
@@ -3296,8 +3295,6 @@
 	"confirm-markpatrolled-button": "OK",
 	"confirm-markpatrolled-top": "Mark revision $3 of $2 as patrolled?",
 	"deletedrevision": "Deleted old revision $1",
-	"filedeleteerror-short": "Error deleting file: $1",
-	"filedeleteerror-long": "Errors were encountered while deleting the file:\n\n$1",
 	"filedelete-missing": "The file \"$1\" cannot be deleted because it does not exist.",
 	"filedelete-old-unregistered": "The specified file revision \"$1\" is not in the database.",
 	"filedelete-current-unregistered": "The specified file \"$1\" is not in the database.",
diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json
index 77d230a39498..afb03e162a1f 100644
--- a/languages/i18n/qqq.json
+++ b/languages/i18n/qqq.json
@@ -2799,7 +2799,6 @@
 	"undelete-comment-dropdown-unsuppress": "Used in [[Special:Undelete]].\nDefault reasons for unsuppressions. Displayed as a drop-down list. Format:\n<pre>* Group\n** Common unsuppress reason\n** ...</pre>",
 	"undelete-edit-commentlist": "Used in [[Special:Undelete]].\nShown beneath the undelete form on the right side. It is a link to {{msg-mw|Undelete-comment-dropdown|notext=1}}.\n\nSee also:\n* {{msg-mw|Ipb-edit-dropdown}}\n* {{msg-mw|Protect-edit-reasonlist}}.\n{{Identical|Edit delete reasons}}",
 	"undelete-edit-commentlist-unsuppress": "Used in [[Special:Undelete]].\nShown beneath the undelete form on the right side. It is a link to {{msg-mw|Undelete-comment-dropdown-unsuppress|notext=1}}.\n\nSee also:\n* {{msg-mw|Ipb-edit-dropdown}}\n* {{msg-mw|Protect-edit-reasonlist}}.\n{{Identical|Edit delete reasons}}",
-	"cannotundelete": "Message shown when undeletion failed for some reason. Parameters:\n* $1 - the combined wikitext of messages for all errors that caused the failure",
 	"undeletedpage": "Used as success message. Parameters:\n* $1 - page title, with link",
 	"undelete-header": "Used in [[Special:Undelete]].",
 	"undelete-search-title": "Page title when showing the search form in [[Special:Undelete]].\n\nSee also:\n* {{msg-mw|undelete-search-box}}\n* {{msg-mw|undelete-search-prefix}}\n* {{msg-mw|undelete-search-full}}\n* {{msg-mw|undelete-search-submit}}",
@@ -3559,8 +3558,6 @@
 	"confirm-markpatrolled-button": "Used as Submit button text.\n{{Identical|OK}}",
 	"confirm-markpatrolled-top": "Confirmation message on interstitial form.\n\nParameters:\n* $1 - Target page title\n* $2 - Link to target page with page title as label\n* $3 - Link to recent change diff with revision ID as label",
 	"deletedrevision": "Used as log comment. Parameters:\n* $1 - archive name of old image",
-	"filedeleteerror-short": "Used as error message. Parameters:\n* $1 – There are two uses: 1) filename or 2) more specific error message like {{msg-mw|Backend-fail-internal}}.\nSee also:\n* {{msg-mw|Filedeleteerror-long}}",
-	"filedeleteerror-long": "Used as error message. Parameters:\n* $1 - ...\nSee also:\n* {{msg-mw|Filedeleteerror-short}}",
 	"filedelete-missing": "Used as error message. Parameters:\n* $1 - filename\nSee also:\n* {{msg-mw|Filedelete-old-unregistered}}\n* {{msg-mw|Filedelete-current-unregistered}}",
 	"filedelete-old-unregistered": "Used as error message. Parameters:\n* $1 - name\nSee also:\n* {{msg-mw|Filedelete-current-unregistered}}\n* {{msg-mw|Filedelete-missing}}",
 	"filedelete-current-unregistered": "Used as error message. Parameters:\n* $1 - filename\nSee also:\n* {{msg-mw|Filedelete-old-unregistered}}\n* {{msg-mw|Filedelete-missing}}",