diff options
| author | pmolina <patriciomolina@gmail.com> | 2012-06-02 12:11:19 -0300 |
|---|---|---|
| committer | Siebrand Mazeland <s.mazeland@xs4all.nl> | 2012-06-04 09:42:42 +0200 |
| commit | 69591db3b467d7d8534a1dcd969685f7c62ea508 (patch) | |
| tree | 8dbb45e11b89f165475e554adac8ebd6e74abf4b /includes | |
| parent | 1267e41a2a7ed8cdbcbf664806c37e2c274b5431 (diff) | |
| download | mediawikicore-69591db3b467d7d8534a1dcd969685f7c62ea508.tar.gz mediawikicore-69591db3b467d7d8534a1dcd969685f7c62ea508.zip | |
(bug 37180) Removed hard coded parentheses in SpecialVersion.php
Patch set 4:
* Use params() instead of rawParams() because there is no need for raw.
* Specify processing explicitely.
Change-Id: If5f1c26f221bdb060b5944ef5e3cdb64d76154e3
Diffstat (limited to 'includes')
| -rw-r--r-- | includes/specials/SpecialVersion.php | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/includes/specials/SpecialVersion.php b/includes/specials/SpecialVersion.php index 2b4dc9555b86..5a71ccb5e1f3 100644 --- a/includes/specials/SpecialVersion.php +++ b/includes/specials/SpecialVersion.php @@ -167,7 +167,8 @@ class SpecialVersion extends SpecialPage { $version = $wgVersion; } elseif ( $gitInfo ) { $shortSha1 = substr( $gitInfo, 0, 7 ); - $version = "$wgVersion ($shortSha1)"; + $shortSha1 = wfMessage( 'parentheses' )->params( $shortSha1 )->escaped(); + $version = "$wgVersion $shortSha1"; } elseif ( $flags === 'nodb' ) { $version = "$wgVersion (r{$svnInfo['checkout-rev']})"; } else { @@ -615,8 +616,8 @@ class SpecialVersion extends SpecialPage { $list = $list[0]; } if( is_object( $list ) ) { - $class = get_class( $list ); - return "($class)"; + $class = wfMessage( 'parentheses' )->params( get_class( $list ) )->escaped(); + return $class; } elseif ( !is_array( $list ) ) { return $list; } else { @@ -625,7 +626,7 @@ class SpecialVersion extends SpecialPage { } else { $class = $list[0]; } - return "($class, {$list[1]})"; + return wfMessage( 'parentheses' )->params( "$class, {$list[1]}" )->escaped(); } } |