diff options
| author | C. Scott Ananian <cscott@cscott.net> | 2024-01-26 18:07:27 -0500 |
|---|---|---|
| committer | C. Scott Ananian <cscott@cscott.net> | 2024-02-12 10:44:59 -0500 |
| commit | c705f1b9d74f80122ddff930f46eadd1a6270041 (patch) | |
| tree | e3b2acc053e6a0f775166c2d09fa54db5df1e303 /includes/title | |
| parent | 0ecd8c151d617a4de94c31b2a9c1d6207a84b9fa (diff) | |
| download | mediawikicore-c705f1b9d74f80122ddff930f46eadd1a6270041.tar.gz mediawikicore-c705f1b9d74f80122ddff930f46eadd1a6270041.zip | |
ParserTestRunner: Fix behavior of bare `parsoid-compatible` file option
The intent was that a `parsoid-compatible` flag without specified modes
would enable all of the parsoid modes. However, the value of
`$fileOptions['parsoid-compatible']` in that case is '', and the
test was looking specifically for a null or false value, not a falsey
one.
This exposed a bug where, because the LinkCache was destroyed and reset,
the calls to Title::clearCaches() didn't have the expected effect, since
the LinkCache held by Title was different from the one held by the
PageStore. This caused the wrong page IDs to be associated with titles,
which then in turn caused the Disambiguator extension (which looks up
page properties by page id) to return the wrong results.
Depends-On: Ib65dd0adb472da53823c07af5991a140374501e4
Depends-On: Id9d6b3ab9d168048f46b1ab8783d06a7cbc9e6d4
Change-Id: Ifca13393c3bbec27c23cbdc311d4550fbccf21ca
Diffstat (limited to 'includes/title')
| -rw-r--r-- | includes/title/Title.php | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/includes/title/Title.php b/includes/title/Title.php index 30a8a332466f..979584a96ac8 100644 --- a/includes/title/Title.php +++ b/includes/title/Title.php @@ -3855,7 +3855,7 @@ class Title implements LinkTarget, PageIdentity, IDBAccessObject { * If this ID is 0, this means the page does not exist. * * @see getArticleID() - * @since 1.36, since 1.35.6 as an alias of getArticleId() + * @since 1.36, since 1.35.6 as an alias of getArticleID() * * @param string|false $wikiId The wiki ID expected by the caller. * |