Shell\Result: declare types, enable strict types

This is a very limited value class created in just one place, so it
looks like a good candidate for experimenting with strict types.

Change-Id: I777c713f8b3be6688c327f7e6fcf97cc9b7ab66e

1 files changed, 6 insertions, 4 deletions

diff --git a/includes/shell/Result.php b/includes/shell/Result.php
index a105cd12d31e..8f469146f8d1 100644
--- a/includes/shell/Result.php
+++ b/includes/shell/Result.php
@@ -18,6 +18,8 @@
  * @file
  */
 
+declare( strict_types = 1 );
+
 namespace MediaWiki\Shell;
 
 /**
@@ -40,7 +42,7 @@ class Result {
 	 * @param string $stdout
 	 * @param string|null $stderr
 	 */
-	public function __construct( $exitCode, $stdout, $stderr = null ) {
+	public function __construct( int $exitCode, string $stdout, ?string $stderr ) {
 		$this->exitCode = $exitCode;
 		$this->stdout = $stdout;
 		$this->stderr = $stderr;
@@ -51,7 +53,7 @@ class Result {
 	 *
 	 * @return int
 	 */
-	public function getExitCode() {
+	public function getExitCode() : int {
 		return $this->exitCode;
 	}
 
@@ -60,7 +62,7 @@ class Result {
 	 *
 	 * @return string
 	 */
-	public function getStdout() {
+	public function getStdout() : string {
 		return $this->stdout;
 	}
 
@@ -70,7 +72,7 @@ class Result {
 	 *
 	 * @return string|null
 	 */
-	public function getStderr() {
+	public function getStderr() : ?string {
 		return $this->stderr;
 	}
 }