diff options
| author | Daimona Eaytoy <daimona.wiki@gmail.com> | 2019-08-31 18:14:38 +0200 |
|---|---|---|
| committer | Krinkle <krinklemail@gmail.com> | 2019-09-03 17:19:21 +0000 |
| commit | c659bc63087b10d8765056500a8ed4bce6cfdbf4 (patch) | |
| tree | 80d5b9f3169b4fb9bebfd6d84b4d3215793fb870 /includes/session | |
| parent | ed398c0253e36f85d39452b00d3273867fe0b8ef (diff) | |
| download | mediawikicore-c659bc63087b10d8765056500a8ed4bce6cfdbf4.tar.gz mediawikicore-c659bc63087b10d8765056500a8ed4bce6cfdbf4.zip | |
Unsuppress another phan issue (part 7)
Bug: T231636
Depends-On: I2cd24e73726394e3200a570c45d5e86b6849bfa9
Depends-On: I4fa3e6aad872434ca397325ed7a83f94973661d0
Change-Id: Ie6233561de78457cae5e4e44e220feec2d1272d8
Diffstat (limited to 'includes/session')
| -rw-r--r-- | includes/session/PHPSessionHandler.php | 6 | ||||
| -rw-r--r-- | includes/session/SessionInfo.php | 1 | ||||
| -rw-r--r-- | includes/session/SessionManager.php | 3 |
3 files changed, 5 insertions, 5 deletions
diff --git a/includes/session/PHPSessionHandler.php b/includes/session/PHPSessionHandler.php index 64c2b84d8dba..a0b024e64213 100644 --- a/includes/session/PHPSessionHandler.php +++ b/includes/session/PHPSessionHandler.php @@ -54,7 +54,7 @@ class PHPSessionHandler implements \SessionHandlerInterface { /** @var array Track original session fields for later modification check */ protected $sessionFieldCache = []; - protected function __construct( SessionManagerInterface $manager ) { + protected function __construct( SessionManager $manager ) { $this->setEnableFlags( \RequestContext::getMain()->getConfig()->get( 'PHPSessionHandling' ) ); @@ -106,9 +106,9 @@ class PHPSessionHandler implements \SessionHandlerInterface { /** * Install a session handler for the current web request - * @param SessionManagerInterface $manager + * @param SessionManager $manager */ - public static function install( SessionManagerInterface $manager ) { + public static function install( SessionManager $manager ) { if ( self::$instance ) { $manager->setupPHPSessionHandler( self::$instance ); return; diff --git a/includes/session/SessionInfo.php b/includes/session/SessionInfo.php index a7bbcce2e2fd..882eb390ccb0 100644 --- a/includes/session/SessionInfo.php +++ b/includes/session/SessionInfo.php @@ -156,6 +156,7 @@ class SessionInfo { $this->idIsSafe = $data['idIsSafe']; $this->forceUse = $data['forceUse'] && $this->provider; } else { + // @phan-suppress-next-line PhanUndeclaredMethod $this->id = $this->provider->getManager()->generateSessionId(); $this->idIsSafe = true; $this->forceUse = false; diff --git a/includes/session/SessionManager.php b/includes/session/SessionManager.php index fc117a8c9c34..fcc428da6e1d 100644 --- a/includes/session/SessionManager.php +++ b/includes/session/SessionManager.php @@ -86,8 +86,7 @@ final class SessionManager implements SessionManagerInterface { /** * Get the global SessionManager - * @return SessionManagerInterface - * (really a SessionManager, but this is to make IDEs less confused) + * @return self */ public static function singleton() { if ( self::$instance === null ) { |