Refactor global variables to use MediaWikiServices instead

Automatically refactors wg prefixed globals to use MediaWikiServices config using Rector. Doesn't include files that set globals or files that fail CI.

Rector Gist: https://gist.github.com/tchin25/7cc54f6d23aedef010b22e4dfbead228

* This patch uses a modified source code rector library for our specific use case and the rector will have different effects without it.

A writeup for future reference is here: https://meta.wikimedia.org/wiki/User:TChin_(WMF)/Using_Rector_On_MediaWiki

Change-Id: I1a691f01cd82e60bf41207d32501edb4b9835e37

1 files changed, 4 insertions, 2 deletions

diff --git a/includes/revisiondelete/RevisionDeleteUser.php b/includes/revisiondelete/RevisionDeleteUser.php
index 9959541a739d..097c5f66544b 100644
--- a/includes/revisiondelete/RevisionDeleteUser.php
+++ b/includes/revisiondelete/RevisionDeleteUser.php
@@ -21,6 +21,7 @@
  * @ingroup RevisionDelete
  */
 
+use MediaWiki\MediaWikiServices;
 use MediaWiki\Revision\RevisionRecord;
 use Wikimedia\Rdbms\IDatabase;
 
@@ -44,7 +45,8 @@ class RevisionDeleteUser {
 	 * @return bool True on success, false on failure (e.g. invalid user ID)
 	 */
 	private static function setUsernameBitfields( $name, $userId, $op, IDatabase $dbw = null ) {
-		global $wgActorTableSchemaMigrationStage;
+		$actorTableSchemaMigrationStage = MediaWikiServices::getInstance()
+			->getMainConfig()->get( 'ActorTableSchemaMigrationStage' );
 
 		if ( !$userId || ( $op !== '|' && $op !== '&' ) ) {
 			return false;
@@ -76,7 +78,7 @@ class RevisionDeleteUser {
 			# write stage, because the stage determines how we find the rows to
 			# delete. The write stage determines whether or not to write to
 			# rev_actor and revision_actor_temp which is not relevant here.
-			if ( $wgActorTableSchemaMigrationStage & SCHEMA_COMPAT_READ_TEMP ) {
+			if ( $actorTableSchemaMigrationStage & SCHEMA_COMPAT_READ_TEMP ) {
 				$ids = $dbw->selectFieldValues(
 					'revision_actor_temp', 'revactor_rev', [ 'revactor_actor' => $actorId ], __METHOD__
 				);