Use strict types in includes/password

This is a well isolated area of code, without functions that are
likely to receive PHP's trademark "garbage in, garbage out" data
as parameters. Capitalize on this and require strict types there.

Change-Id: I9f1c172e737018d058ddc1700d8234832b58efa6

1 files changed, 6 insertions, 4 deletions

diff --git a/includes/password/BcryptPassword.php b/includes/password/BcryptPassword.php
index 4ba34effe553..2b1fcb7ed4b9 100644
--- a/includes/password/BcryptPassword.php
+++ b/includes/password/BcryptPassword.php
@@ -20,6 +20,8 @@
  * @file
  */
 
+declare( strict_types = 1 );
+
 /**
  * A Bcrypt-hashed password
  *
@@ -29,17 +31,17 @@
  * @since 1.24
  */
 class BcryptPassword extends ParameterizedPassword {
-	protected function getDefaultParams() {
+	protected function getDefaultParams() : array {
 		return [
 			'rounds' => $this->config['cost'],
 		];
 	}
 
-	protected function getDelimiter() {
+	protected function getDelimiter() : string {
 		return '$';
 	}
 
-	protected function parseHash( $hash ) {
+	protected function parseHash( ?string $hash ) : void {
 		parent::parseHash( $hash );
 
 		$this->params['rounds'] = (int)$this->params['rounds'];
@@ -51,7 +53,7 @@ class BcryptPassword extends ParameterizedPassword {
 	 * @throws PasswordError If bcrypt has an unknown error
 	 * @throws MWException If bcrypt is not supported by PHP
 	 */
-	public function crypt( $password ) {
+	public function crypt( string $password ) : void {
 		if ( !defined( 'CRYPT_BLOWFISH' ) ) {
 			throw new MWException( 'Bcrypt is not supported.' );
 		}