diff options
author | Umherirrender <umherirrender_de.wp@web.de> | 2020-06-14 21:25:55 +0200 |
---|---|---|
committer | Umherirrender <umherirrender_de.wp@web.de> | 2020-06-14 21:25:55 +0200 |
commit | 19a1b7b5d424b716ee8baaf5213fbb95245ef75c (patch) | |
tree | 4fd28a2acad13f6ad019600f841e56ff3bf2384b /includes/parser/LinkHolderArray.php | |
parent | c1578fa01720c7a8d9d90d9bdd31a3768f5998a5 (diff) | |
download | mediawikicore-19a1b7b5d424b716ee8baaf5213fbb95245ef75c.tar.gz mediawikicore-19a1b7b5d424b716ee8baaf5213fbb95245ef75c.zip |
Avoid variable reuse in LinkHolderArray
Help taint-check to determine the correct taint of the variable
Change-Id: I943dad3bc3fa495b78f37776f54788b4766fa3b2
Diffstat (limited to 'includes/parser/LinkHolderArray.php')
-rw-r--r-- | includes/parser/LinkHolderArray.php | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/includes/parser/LinkHolderArray.php b/includes/parser/LinkHolderArray.php index 2e5c2df9c44d..97c825f52d91 100644 --- a/includes/parser/LinkHolderArray.php +++ b/includes/parser/LinkHolderArray.php @@ -282,15 +282,15 @@ class LinkHolderArray { $query = $entry['query'] ?? []; $key = "$ns:$index"; $searchkey = "<!--LINK'\" $key-->"; - $displayText = $entry['text']; + $displayTextHtml = $entry['text']; if ( isset( $entry['selflink'] ) ) { - $replacePairs[$searchkey] = Linker::makeSelfLinkObj( $title, $displayText, $query ); + $replacePairs[$searchkey] = Linker::makeSelfLinkObj( $title, $displayTextHtml, $query ); continue; } - if ( $displayText === '' ) { + if ( $displayTextHtml === '' ) { $displayText = null; } else { - $displayText = new HtmlArmor( $displayText ); + $displayText = new HtmlArmor( $displayTextHtml ); } if ( !isset( $colours[$pdbk] ) ) { $colours[$pdbk] = 'new'; |